pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 1927323002: Implement stable resolution of generic types without type arguments to their bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1927323002: Implement stable resolution of generic types without type arguments to their bounds. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merge and regenerate the task graph. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart ('k') | pkg/analysis_server/lib/src/status/get_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index 7be86e4232a8864ce7451774fae6f7480fd4c26a..e582d3713d12b59100ff19098df0696b1925cd94 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -311,7 +311,7 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

CompilationUnit unit = await _computeAsync(

this,

new LibrarySpecificUnit(libElem.source, unresolvedUnit.source),

- RESOLVED_UNIT4,

+ RESOLVED_UNIT5,

performance,

'resolve library unit');

checkAborted();

@@ -388,7 +388,7 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

unit = await _computeAsync(

request,

new LibrarySpecificUnit(libSource, source),

- resultDescriptor ?? RESOLVED_UNIT4,

+ resultDescriptor ?? RESOLVED_UNIT5,

performance,

'resolve declarations');

}