Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1927253002: Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, Part 5 (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, Part 5 Remove unused m_pdf417byteSegments, which was coped into from an empty array and never again referenced. Committed: https://pdfium.googlesource.com/pdfium/+/33a747db5c9ce18bdfaaaaea17b03ef26d14ff54

Patch Set 1 #

Patch Set 2 : One less pointless bubblesort. #

Patch Set 3 : Unused fn. #

Total comments: 4

Patch Set 4 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -96 lines) Patch
M xfa/fxbarcode/common/BC_CommonDecoderResult.h View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/fxbarcode/common/BC_CommonDecoderResult.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h View 1 2 3 1 chunk +9 lines, -7 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_FinderPatternInfo.cpp View 1 chunk +12 lines, -7 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.h View 2 chunks +10 lines, -10 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRFinderPattern.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRFinderPattern.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRFinderPatternFinder.h View 3 chunks +15 lines, -13 lines 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRFinderPatternFinder.cpp View 1 2 9 chunks +49 lines, -44 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-04-28 20:42:00 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1927253002/diff/40001/xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h File xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h (right): https://codereview.chromium.org/1927253002/diff/40001/xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h#newcode16 xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h:16: CBC_QRFinderPatternInfo( explicit https://codereview.chromium.org/1927253002/diff/40001/xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h#newcode18 xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h:18: virtual ~CBC_QRFinderPatternInfo(); no need ...
4 years, 7 months ago (2016-04-28 21:26:12 UTC) #3
Tom Sepez
https://codereview.chromium.org/1927253002/diff/40001/xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h File xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h (right): https://codereview.chromium.org/1927253002/diff/40001/xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h#newcode16 xfa/fxbarcode/qrcode/BC_FinderPatternInfo.h:16: CBC_QRFinderPatternInfo( On 2016/04/28 21:26:12, Lei Zhang wrote: > explicit ...
4 years, 7 months ago (2016-04-28 22:03:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927253002/60001
4 years, 7 months ago (2016-04-28 22:04:02 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 22:16:54 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/33a747db5c9ce18bdfaaaaea17b03ef26d14...

Powered by Google App Engine
This is Rietveld 408576698