Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, Part 5

xfa/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2007 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 22 matching lines @@
     int32_t height,
     FX_FLOAT moduleSize)
     : m_image(image),
       m_startX(startX),
       m_startY(startY),
       m_width(width),
       m_height(height),
       m_moduleSize(moduleSize) {
   m_crossCheckStateCount.SetSize(3);
 }
+
 CBC_QRAlignmentPatternFinder::~CBC_QRAlignmentPatternFinder() {
-  for (int32_t i = 0; i < m_possibleCenters.GetSize(); i++) {
-    delete (CBC_QRAlignmentPattern*)m_possibleCenters[i];
-  }
-  m_possibleCenters.RemoveAll();
+  for (int32_t i = 0; i < m_possibleCenters.GetSize(); i++)
+    delete m_possibleCenters[i];
 }
+
 CBC_QRAlignmentPattern* CBC_QRAlignmentPatternFinder::Find(int32_t& e) {
   int32_t startX = m_startX;
   int32_t height = m_height;
   int32_t maxJ = startX + m_width;
   int32_t middleI = m_startY + (height >> 1);
   CFX_Int32Array stateCount;
   stateCount.SetSize(3);
   for (int32_t iGen = 0; iGen < height; iGen++) {
     int32_t i =
         middleI + ((iGen & 0x01) == 0 ? ((iGen + 1) >> 1) : -((iGen + 1) >> 1));
@@ skipping 36 matching lines @@
     }
     if (FoundPatternCross(stateCount)) {
       CBC_QRAlignmentPattern* confirmed =
           HandlePossibleCenter(stateCount, i, maxJ);
       if (confirmed) {
         return confirmed;
       }
     }
   }
   if (m_possibleCenters.GetSize() != 0) {
-    return ((CBC_QRAlignmentPattern*)(m_possibleCenters[0]))->Clone();
+    return m_possibleCenters[0]->Clone();
   }
   e = BCExceptionRead;
   BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
   return NULL;
 }
 FX_FLOAT CBC_QRAlignmentPatternFinder::CenterFromEnd(
     const CFX_Int32Array& stateCount,
     int32_t end) {
   return (FX_FLOAT)(end - stateCount[2]) - stateCount[1] / 2.0f;
 }
@@ skipping 63 matching lines @@
     int32_t j) {
   int32_t stateCountTotal = stateCount[0] + stateCount[1] + stateCount[2];
   FX_FLOAT centerJ = CenterFromEnd(stateCount, j);
   FX_FLOAT centerI = CrossCheckVertical(i, (int32_t)centerJ, 2 * stateCount[1],
                                         stateCountTotal);
   if (!FXSYS_isnan(centerI)) {
     FX_FLOAT estimatedModuleSize =
         (FX_FLOAT)(stateCount[0] + stateCount[1] + stateCount[2]) / 3.0f;
     int32_t max = m_possibleCenters.GetSize();
     for (int32_t index = 0; index < max; index++) {
-      CBC_QRAlignmentPattern* center =
-          (CBC_QRAlignmentPattern*)(m_possibleCenters[index]);
+      CBC_QRAlignmentPattern* center = m_possibleCenters[index];
       if (center->AboutEquals(estimatedModuleSize, centerI, centerJ)) {
         return new CBC_QRAlignmentPattern(centerJ, centerI,
                                           estimatedModuleSize);
       }
     }
     m_possibleCenters.Add(
         new CBC_QRAlignmentPattern(centerJ, centerI, estimatedModuleSize));
   }
   return NULL;
 }