Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1927143003: Require explicit user action for shipping address. (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require explicit user action for shipping address. This patch makes PaymentRequest require an explicit user action to provide their shipping address to the merchant website. This applies only to the merchants that request shipping address from PaymentRequest. If merchant provides NO SHIPPING OPTIONS in first request: - Merchant needs an address for calculations. PaymentRequest requires the user to make an address selection to send to the merchant. If merchant provides a SINGLE SHIPPING OPTION in first request: - Merchant supports shipping worldwide at the same cost. PaymentRequest selects the default address and the only shipping option. The merchant gets the address when the user clicks "Pay" in PaymentRequest. If merchant provides MULTIPLE SHIPPING OPTIONS in first request: - Merchant supports shipping worldwide at different costs. PaymentRequest requires the user to make an address selection to send to the merchant. BUG=607672 Committed: https://crrev.com/6862d5f1cc6a54b2aac91da08acf842efd5778a0 Cr-Commit-Position: refs/heads/master@{#390512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/android/java/res/layout/payment_request.xml View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 chunk +18 lines, -9 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
please use gerrit instead
dfalcantara@, ptal. I hope I'm not stepping on your toes by changing PaymentRequestUI. Let me ...
4 years, 7 months ago (2016-04-28 21:52:09 UTC) #5
gone
lgtm
4 years, 7 months ago (2016-04-28 22:14:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1927143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1927143003/1
4 years, 7 months ago (2016-04-28 22:18:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 22:31:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:22:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6862d5f1cc6a54b2aac91da08acf842efd5778a0
Cr-Commit-Position: refs/heads/master@{#390512}

Powered by Google App Engine
This is Rietveld 408576698