chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 1927143003: Require explicit user action for shipping address.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 1927143003: Require explicit user action for shipping address. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/payment_request.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 27347ea9d5f8e6801f2a5283b1d29d94aea867f6..3639f168f620a1c0b7deda784de5102e37789298 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -187,9 +187,10 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

if (addresses.isEmpty()) {

mShippingAddresses = new SectionInformation();

- } else {

+ } else if (mShippingOptions.getSelectedItem() != null) {

mShippingAddresses = new SectionInformation(0, addresses);

- onShippingAddressChanged(addresses.get(0));

+ } else {

+ mShippingAddresses = new SectionInformation(SectionInformation.NO_SELECTION, addresses);

}

mPendingApps = new ArrayList<>(mApps);