[mac] Remove dependencies from BrowserCompositorOverlayCandidateValidatorMac.

[mac] Remove dependencies from BrowserCompositorOverlayCandidateValidatorMac.

Tell BrowserCompositorOverlayCandidateValidatorMac about CALayer support, so
that it doesn't have to depend on GpuDataManagerImpl or the cmdline switches.

BUG=601868
Committed: https://crrev.com/799b83d6b29d3069a9fa40d563103e1beeea8ef4
Cr-Commit-Position: refs/heads/master@{#390562}

[sadrul, 2016-04-28 01:12:41]

sadrul@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2016-04-28 23:07:56]

lgtm

https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
File
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h
(right):

https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h:22:
DISABLED_DRIVER,   // Disabled because of driver bug.
This level of granularity may not, but I see no reason to not have it.

https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
File
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
(right):

https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm:35:
if (ca_layer_support_ == CALayerSupport::DISABLED_DRIVER)
This function is no longer needed and can just return (we only support CALayer
overlays, no "other" overlays).

[sadrul, 2016-04-28 23:13:08]

https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
File
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
(right):

https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm:35:
if (ca_layer_support_ == CALayerSupport::DISABLED_DRIVER)
On 2016/04/28 23:07:56, ccameron wrote:
> This function is no longer needed and can just return (we only support CALayer
> overlays, no "other" overlays).

Do you mean this function can just be empty? (because if so, then the
CALayerSupport enum can be a single bool, and make things simpler)

[ccameron, 2016-04-28 23:26:38]

On 2016/04/28 23:13:08, sadrul wrote:
>
https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
> File
>
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
> (right):
> 
>
https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
>
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm:35:
> if (ca_layer_support_ == CALayerSupport::DISABLED_DRIVER)
> On 2016/04/28 23:07:56, ccameron wrote:
> > This function is no longer needed and can just return (we only support
CALayer
> > overlays, no "other" overlays).
> 
> Do you mean this function can just be empty? (because if so, then the
> CALayerSupport enum can be a single bool, and make things simpler)

Yes, exactly, it can be a bool b/c that function can be empty.

[sadrul, 2016-04-29 01:31:03]

On 2016/04/28 23:26:38, ccameron wrote:
> On 2016/04/28 23:13:08, sadrul wrote:
> >
>
https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
> > File
> >
>
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
> > (right):
> > 
> >
>
https://codereview.chromium.org/1926973003/diff/40001/content/browser/composi...
> >
>
content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm:35:
> > if (ca_layer_support_ == CALayerSupport::DISABLED_DRIVER)
> > On 2016/04/28 23:07:56, ccameron wrote:
> > > This function is no longer needed and can just return (we only support
> CALayer
> > > overlays, no "other" overlays).
> > 
> > Do you mean this function can just be empty? (because if so, then the
> > CALayerSupport enum can be a single bool, and make things simpler)
> 
> Yes, exactly, it can be a bool b/c that function can be empty.

Cool, thanks! Done.

[sadrul, 2016-04-29 01:36:22]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-04-29 01:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/1926973003/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-04-29 01:36:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926973003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926973003/100001

[commit-bot: I haz the power, 2016-04-29 01:41:32]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:23:28]

Patchset 6 (id:??) landed as
https://crrev.com/799b83d6b29d3069a9fa40d563103e1beeea8ef4
Cr-Commit-Position: refs/heads/master@{#390562}

[commit-bot: I haz the power, 2016-04-30 17:58:52]

Description was changed from

==========
[mac] Remove dependencies from BrowserCompositorOverlayCandidateValidatorMac.

Tell BrowserCompositorOverlayCandidateValidatorMac about CALayer support, so
that it doesn't have to depend on GpuDataManagerImpl or the cmdline switches.

BUG=601868
==========

to

==========
[mac] Remove dependencies from BrowserCompositorOverlayCandidateValidatorMac.

Tell BrowserCompositorOverlayCandidateValidatorMac about CALayer support, so
that it doesn't have to depend on GpuDataManagerImpl or the cmdline switches.

BUG=601868

Committed: https://crrev.com/799b83d6b29d3069a9fa40d563103e1beeea8ef4
Cr-Commit-Position: refs/heads/master@{#390562}
==========