Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1931213002: display_compositor: Move CompositorOverlayCandidateValidator from content. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@DONE_2016.04.28_dc-overlay-candidate-validator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

display_compositor: Move CompositorOverlayCandidateValidator from content. Remove Browser prefix from BrowserCompositorOverlayCandidateValidator, and move it (and the implementations) into //components/display_compositor/ from //content/browser/compositor/. BUG=601868 Committed: https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883 Cr-Commit-Position: refs/heads/master@{#391233}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -466 lines) Patch
M components/display_compositor.gypi View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M components/display_compositor/BUILD.gn View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M components/display_compositor/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator.h View 1 2 3 1 chunk +11 lines, -12 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator_android.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator_android.cc View 3 chunks +11 lines, -11 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator_mac.h View 2 chunks +13 lines, -13 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator_mac.mm View 1 chunk +13 lines, -16 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator_ozone.h View 1 chunk +13 lines, -12 lines 0 comments Download
A + components/display_compositor/compositor_overlay_candidate_validator_ozone.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator.h View 1 chunk +0 lines, -29 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator_android.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator_android.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm View 1 chunk +0 lines, -36 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 8 chunks +18 lines, -12 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sadrul
4 years, 7 months ago (2016-04-29 04:29:32 UTC) #2
sadrul
ooh, oops, didn't notice piman was OOO. Sending to danakj@ instead.
4 years, 7 months ago (2016-04-29 04:52:40 UTC) #4
sadrul
ping
4 years, 7 months ago (2016-05-02 17:31:18 UTC) #5
piman
lgtm
4 years, 7 months ago (2016-05-02 20:28:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931213002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931213002/80001
4 years, 7 months ago (2016-05-02 23:46:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/176415)
4 years, 7 months ago (2016-05-02 23:54:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931213002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931213002/80001
4 years, 7 months ago (2016-05-03 13:36:25 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-03 14:48:21 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 14:49:53 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e71355bc5dd3f42af151dc7b7c973fdc8cd1e883
Cr-Commit-Position: refs/heads/master@{#391233}

Powered by Google App Engine
This is Rietveld 408576698