Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1926913002: Moves more code to ash/wm/common (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook, reveman
CC:
chromium-reviews, davemoore+watch_chromium.org, dcheng, kalyank, oshima+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor_workspace_layout_manager
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves more code to ash/wm/common These classes all only depend upon ash/wm/common BUG=603369 TEST=covered by tests R=jamescook@chromium.org TBR=reveman@chromium.org Committed: https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c Cr-Commit-Position: refs/heads/master@{#390311}

Patch Set 1 #

Patch Set 2 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1434 lines) Patch
M ash/ash.gyp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/toplevel_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/always_on_top_controller.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ash/wm/always_on_top_controller.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download
M ash/wm/always_on_top_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/common/always_on_top_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/always_on_top_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/common/window_positioner.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + ash/wm/common/window_positioner.cc View 1 12 chunks +23 lines, -28 lines 0 comments Download
A + ash/wm/common/workspace/workspace_layout_manager.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/common/workspace/workspace_layout_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/wm/common/workspace/workspace_layout_manager_backdrop_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/maximize_mode/workspace_backdrop_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/window_positioner.h View 1 1 chunk +0 lines, -133 lines 0 comments Download
D ash/wm/window_positioner.cc View 1 1 chunk +0 lines, -568 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D ash/wm/workspace/workspace_layout_manager.h View 1 1 chunk +0 lines, -149 lines 0 comments Download
D ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h View 1 chunk +0 lines, -46 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/touch_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
This is a straight move (with a git cl format as enforced by presumit). reveman, ...
4 years, 7 months ago (2016-04-27 21:32:36 UTC) #1
reveman
lgtm
4 years, 7 months ago (2016-04-27 21:50:34 UTC) #2
James Cook
LGTM
4 years, 7 months ago (2016-04-27 23:37:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926913002/20001
4 years, 7 months ago (2016-04-28 05:11:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 05:56:26 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:31 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c
Cr-Commit-Position: refs/heads/master@{#390311}

Powered by Google App Engine
This is Rietveld 408576698