ash/wm/common/always_on_top_controller.cc - Issue 1926913002: Moves more code to ash/wm/common

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/wm/common/always_on_top_controller.cc

Issue 1926913002: Moves more code to ash/wm/common (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_workspace_layout_manager

Patch Set: merge to trunk Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/wm/common/always_on_top_controller.h ('k') | ash/wm/common/window_positioner.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/wm/always_on_top_controller.h"	5 #include "ash/wm/common/always_on_top_controller.h"

6	6

7 #include "ash/wm/common/wm_shell_window_ids.h"	7 #include "ash/wm/common/wm_shell_window_ids.h"

8 #include "ash/wm/common/wm_window.h"	8 #include "ash/wm/common/wm_window.h"

9 #include "ash/wm/common/wm_window_property.h"	9 #include "ash/wm/common/wm_window_property.h"

	10 #include "ash/wm/common/workspace/workspace_layout_manager.h"

10 #include "ash/wm/common/workspace/workspace_layout_manager_delegate.h"	11 #include "ash/wm/common/workspace/workspace_layout_manager_delegate.h"

11 #include "ash/wm/workspace/workspace_layout_manager.h"

12 #include "base/memory/ptr_util.h"	12 #include "base/memory/ptr_util.h"

13	13

14 namespace ash {	14 namespace ash {

15	15

16 AlwaysOnTopController::AlwaysOnTopController(wm::WmWindow* viewport)	16 AlwaysOnTopController::AlwaysOnTopController(wm::WmWindow* viewport)

17 : always_on_top_container_(viewport) {	17 : always_on_top_container_(viewport) {

18 always_on_top_container_->SetLayoutManager(	18 always_on_top_container_->SetLayoutManager(

19 base::WrapUnique(new WorkspaceLayoutManager(viewport, nullptr)));	19 base::WrapUnique(new WorkspaceLayoutManager(viewport, nullptr)));

20 // Container should be empty.	20 // Container should be empty.

21 DCHECK(always_on_top_container_->GetChildren().empty());	21 DCHECK(always_on_top_container_->GetChildren().empty());

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 }	70 }

71	71

72 void AlwaysOnTopController::OnWindowDestroying(wm::WmWindow* window) {	72 void AlwaysOnTopController::OnWindowDestroying(wm::WmWindow* window) {

73 if (window == always_on_top_container_) {	73 if (window == always_on_top_container_) {

74 always_on_top_container_->RemoveObserver(this);	74 always_on_top_container_->RemoveObserver(this);

75 always_on_top_container_ = nullptr;	75 always_on_top_container_ = nullptr;

76 }	76 }

77 }	77 }

78	78

79 } // namespace ash	79 } // namespace ash

OLD	NEW