Make Isolate::GetStackSample API support simulator

src/profiler/sampler.h

Index: src/profiler/sampler.h
diff --git a/src/profiler/sampler.h b/src/profiler/sampler.h
index f6804f8e25f7aa0a328a64b746cd8251115cad90..18ccf49e77066bcbdda5910177d1150f0cffceb5 100644
--- a/src/profiler/sampler.h
+++ b/src/profiler/sampler.h
@@ -11,6 +11,7 @@
 #include "src/base/platform/time.h"
 #include "src/frames.h"
 #include "src/globals.h"
+#include "src/simulator.h"

[alph, 2016/04/29 22:07:33]

leave it in sampler.cc

[lpy, 2016/04/29 22:15:18]

Done.

 
 namespace v8 {
 namespace internal {
@@ -141,6 +142,16 @@ class Sampler {
 };
 
 
+#if defined(USE_SIMULATOR)
+class SimulatorHelper : AllStatic {
+ public:
+  // Returns false when there is no active simulator, or sp is zero,

[alph, 2016/04/29 22:07:33]

nit: you don't need to go into implementation details here.
"Returns true if register values were successfully retrieved from the simulator,
false otherwise." -- should be enough.

[lpy, 2016/04/29 22:15:17]

Done.

+  // or fp is zero, otherwise returns true.
+  static bool FillRegisters(Isolate* isolate, v8::RegisterState* state);
+};
+#endif  // USE_SIMULATOR
+
+
 }  // namespace internal
 }  // namespace v8