Make Isolate::GetStackSample API support simulator

src/profiler/sampler.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PROFILER_SAMPLER_H_
 #define V8_PROFILER_SAMPLER_H_
 
 #include "include/v8.h"
 
 #include "src/base/atomicops.h"
 #include "src/base/platform/time.h"
 #include "src/frames.h"
 #include "src/globals.h"
+#include "src/simulator.h"

[alph, 2016/04/29 22:07:33]

leave it in sampler.cc

[lpy, 2016/04/29 22:15:18]

Done.

 
 namespace v8 {
 namespace internal {
 
 class Isolate;
 
 // ----------------------------------------------------------------------------
 // Sampler
 //
 // A sampler periodically samples the state of the VM and optionally
@@ skipping 110 matching lines @@
   base::Atomic32 registered_;
   PlatformData* data_;  // Platform specific data.
   // Counts stack samples taken in various VM states.
   bool is_counting_samples_;
   unsigned js_sample_count_;
   unsigned external_sample_count_;
   DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler);
 };
 
 
+#if defined(USE_SIMULATOR)
+class SimulatorHelper : AllStatic {
+ public:
+  // Returns false when there is no active simulator, or sp is zero,

[alph, 2016/04/29 22:07:33]

nit: you don't need to go into implementation details here.
"Returns true if register values were successfully retrieved from the simulator,
false otherwise." -- should be enough.

[lpy, 2016/04/29 22:15:17]

Done.

+  // or fp is zero, otherwise returns true.
+  static bool FillRegisters(Isolate* isolate, v8::RegisterState* state);
+};
+#endif  // USE_SIMULATOR
+
+
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PROFILER_SAMPLER_H_