Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1926863002: GC plugin: split out reporting of errors/warnings. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GC plugin: split out reporting of errors/warnings. Move code to handle reporting of errors and notes out into a class of its own. R=haraken BUG=531879 Committed: https://crrev.com/adf651b15bed4b52b4aad5b1b0bc8728603fc91e Cr-Commit-Position: refs/heads/master@{#390350}

Patch Set 1 #

Patch Set 2 : sort CMakeLists list #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+704 lines, -642 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.h View 3 chunks +3 lines, -106 lines 0 comments Download
M tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp View 1 2 18 chunks +32 lines, -530 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
A tools/clang/blink_gc_plugin/DiagnosticsReporter.h View 1 2 1 chunk +137 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/DiagnosticsReporter.cpp View 1 chunk +527 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
4 years, 7 months ago (2016-04-27 20:23:07 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-28 07:33:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926863002/40001
4 years, 7 months ago (2016-04-28 11:01:42 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 12:07:00 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:35 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/adf651b15bed4b52b4aad5b1b0bc8728603fc91e
Cr-Commit-Position: refs/heads/master@{#390350}

Powered by Google App Engine
This is Rietveld 408576698