Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h

Issue 1926863002: GC plugin: split out reporting of errors/warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whitespace Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/CMakeLists.txt ('k') | tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
diff --git a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
index d700be2ae0201fc78f49389721580da92daad116..4fddede3808738b04c3bb6f73ea03c43940ac7fb 100644
--- a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
+++ b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.h
@@ -31,9 +31,9 @@ class CheckFieldsVisitor : public RecursiveEdgeVisitor {
kGCDerivedPartObject
};
- typedef std::vector<std::pair<FieldPoint*, Error> > Errors;
+ using Errors = std::vector<std::pair<FieldPoint*, Error>>;
- explicit CheckFieldsVisitor(const BlinkGCPluginOptions& options);
+ CheckFieldsVisitor();
Errors& invalid_fields();
@@ -46,7 +46,6 @@ class CheckFieldsVisitor : public RecursiveEdgeVisitor {
private:
Error InvalidSmartPtr(Edge* ptr);
- const BlinkGCPluginOptions& options_;
FieldPoint* current_;
bool stack_allocated_host_;
bool managed_host_;
« no previous file with comments | « tools/clang/blink_gc_plugin/CMakeLists.txt ('k') | tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698