Replace assert_promise_rejects with upstream promise_rejects.

Replace assert_promise_rejects with upstream promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method, and delete testharness-helpers.js
as the file would now be empty.

Committed: https://crrev.com/3d1cdd336f0646e058d4de65a656125c69a0a896
Cr-Commit-Position: refs/heads/master@{#392635}

[Marijn Kruisselbrink, 2016-04-27 20:25:53]

Patchset #1 (id:1) has been deleted

[Marijn Kruisselbrink, 2016-04-27 20:25:57]

Patchset #1 (id:20001) has been deleted

[Marijn Kruisselbrink, 2016-04-27 21:01:27]

Patchset #1 (id:40001) has been deleted

[Marijn Kruisselbrink, 2016-04-27 23:14:23]

mek@chromium.org changed reviewers:
+ jsbell@chromium.org

[Marijn Kruisselbrink, 2016-04-27 23:14:24]

Removing duplications between testharness.js and testharness-helpers.js seems
like a good idea. I should possibly wait with landing this until after something
like https://github.com/w3c/testharness.js/pull/191 gets merged into
testharness.js to retain feature parity between the two versions of the
promise_rejects tests.

[Marijn Kruisselbrink, 2016-04-28 19:08:05]

Description was changed from

==========
Remove assert_promise_rejects in favor of upstream version.

Upstream testharness.js added promise_rejects(). This replaces all uses
of assert_promise_rejects with that promise_rejects method.

Also fixes an issue in the fast/imagecapture test to actually wait for
the result of the promise rejection tests before declaring the test as
done.
==========

to

==========
Update testharness.js and remove our assert_promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method.

Also fixes an issue in the fast/imagecapture test to actually wait for
the result of the promise rejection tests before declaring the test as
done.
==========

[Marijn Kruisselbrink, 2016-04-28 19:08:10]

Description was changed from

==========
Update testharness.js and remove our assert_promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method.

Also fixes an issue in the fast/imagecapture test to actually wait for
the result of the promise rejection tests before declaring the test as
done.
==========

to

==========
Update testharness.js and remove our assert_promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method.
==========

[Marijn Kruisselbrink, 2016-04-28 19:10:46]

On 2016/04/27 at 23:14:24, Marijn Kruisselbrink wrote:
> Removing duplications between testharness.js and testharness-helpers.js seems
like a good idea. I should possibly wait with landing this until after something
like https://github.com/w3c/testharness.js/pull/191 gets merged into
testharness.js to retain feature parity between the two versions of the
promise_rejects tests.

Okay, that pull request was merged so I updated this CL with the new
testharness.js changes. Although maybe I should have updated testharness.js in a
separate CL?

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation.html
(right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation.html:25:
promise_rejects(this,
These changes aren't strictly correct, but they're not making this completely
broken test any more broken than it already is. So rather than trying to fix
everything that's wrong with this test I'm just keeping the existing broken
non-behavior (in PS1 I tried to fix it, but changes made to these tests
yesterday broke this test even more, to the point that fixing it is more work
than I'm willing to spend on it).

[jsbell, 2016-04-29 17:29:03]

LayoutTests/imported should only be updated as a result of the process at
https://www.chromium.org/blink/importing-the-w3c-tests. 

It looks like we need to update the version of testharness.js upstream in
web-platform-tests then do an update per the process above.

[jsbell, 2016-04-29 17:39:07]

Thanks for taking on this cleanup!

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/bluetooth/requestDevice.html (right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/requestDevice.html:3: <script
src="../resources/testharness-helpers.js"></script>
This include isn't needed any more, is it?

(applies to most of the files in this CL)

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation.html
(right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation.html:25:
promise_rejects(this,
On 2016/04/28 19:10:46, Marijn Kruisselbrink wrote:
> These changes aren't strictly correct, but they're not making this completely
> broken test any more broken than it already is. So rather than trying to fix
> everything that's wrong with this test I'm just keeping the existing broken
> non-behavior (in PS1 I tried to fix it, but changes made to these tests
> yesterday broke this test even more, to the point that fixing it is more work
> than I'm willing to spend on it).

Acknowledged.

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js
(right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-add.js:8:
return promise_rejects(
I don't suppose you want to make the same changes to the copies of these in
web-platform-tests?

https://github.com/w3c/web-platform-tests/blob/master/service-workers/cache-s...

(etc)

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js
(right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js:18:
function assert_will_be_idl_attribute(object, attribute_name, description) {
aside: we can probably remove this now (separate CL)

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js:33:
function stringifyDOMObject(object)
aside: code search tells me there is now just one use of this. we should remove
(separate CL)

[jsbell, 2016-04-29 19:09:41]

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js
(right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js:18:
function assert_will_be_idl_attribute(object, attribute_name, description) {
On 2016/04/29 17:39:07, jsbell wrote:
> aside: we can probably remove this now (separate CL)

https://codereview.chromium.org/1936533003/

[jsbell, 2016-04-29 21:16:42]

Sorry for the spam, but for documentation purposes...

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js
(right):

https://codereview.chromium.org/1926813004/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/resources/testharness-helpers.js:33:
function stringifyDOMObject(object)
On 2016/04/29 17:39:07, jsbell wrote:
> aside: code search tells me there is now just one use of this. we should
remove
> (separate CL)

https://codereview.chromium.org/1935703003

[jsbell, 2016-05-09 16:57:01]

FYI https://codereview.chromium.org/1962003002/ is in the CQ and should bring in
the needed testharness.js update

[jsbell, 2016-05-09 22:29:36]

On 2016/05/09 16:57:01, jsbell wrote:
> FYI https://codereview.chromium.org/1962003002/ is in the CQ and should bring
in
> the needed testharness.js update

... and that's in so this should be unblocked now!

[Marijn Kruisselbrink, 2016-05-09 23:47:55]

Description was changed from

==========
Update testharness.js and remove our assert_promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method.
==========

to

==========
Update testharness.js and remove our assert_promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method, and delete testharness-helpers.js
as the file would now be empty.
==========

[Marijn Kruisselbrink, 2016-05-10 00:28:48]

Patchset #3 (id:100001) has been deleted

[Marijn Kruisselbrink, 2016-05-10 00:34:44]

On 2016/05/09 at 22:29:36, jsbell wrote:
> On 2016/05/09 16:57:01, jsbell wrote:
> > FYI https://codereview.chromium.org/1962003002/ is in the CQ and should
bring in
> > the needed testharness.js update
> 
> ... and that's in so this should be unblocked now!

Thanks, updated this CL to remove testharness-helpers.js and all references to
it completely.

[jsbell, 2016-05-10 17:12:49]

lgtm

[jsbell, 2016-05-10 17:13:20]

CL name/description should be updated, though.

[Marijn Kruisselbrink, 2016-05-10 17:15:48]

Description was changed from

==========
Update testharness.js and remove our assert_promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method, and delete testharness-helpers.js
as the file would now be empty.
==========

to

==========
Replace assert_promise_rejects with upstream promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method, and delete testharness-helpers.js
as the file would now be empty.
==========

[Marijn Kruisselbrink, 2016-05-10 17:16:04]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-05-10 17:16:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926813004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926813004/120001

[commit-bot: I haz the power, 2016-05-10 17:24:02]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-05-10 17:25:18]

Description was changed from

==========
Replace assert_promise_rejects with upstream promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method, and delete testharness-helpers.js
as the file would now be empty.
==========

to

==========
Replace assert_promise_rejects with upstream promise_rejects.

Upstream testharness.js has a promise_rejects() which does the same as our
assert_promise_rejects method. So replace usage of assert_promise_rejects
with the upstream promise_rejects method, and delete testharness-helpers.js
as the file would now be empty.

Committed: https://crrev.com/3d1cdd336f0646e058d4de65a656125c69a0a896
Cr-Commit-Position: refs/heads/master@{#392635}
==========

[commit-bot: I haz the power, 2016-05-10 17:25:20]

Patchset 3 (id:??) landed as
https://crrev.com/3d1cdd336f0646e058d4de65a656125c69a0a896
Cr-Commit-Position: refs/heads/master@{#392635}