TestRunner: add method to instrument autoplay settings and set default value.

TestRunner: add method to instrument autoplay settings and set default value.

It adds window.testRunner.setAutoplayEnabled(bool) and sets the default
value to true (this is what LayoutTests expects today).

The new method is used in the following CL:
https://codereview.chromium.org/1920863005

BUG=604751
Committed: https://crrev.com/426f286226681c8792c2261c062a73842149ba13
Cr-Commit-Position: refs/heads/master@{#390705}

[mlamouri (slow - plz ping), 2016-04-27 16:14:49]

mlamouri@chromium.org changed reviewers:
+ rbyers@chromium.org

[mlamouri (slow - plz ping), 2016-04-27 16:14:50]

rbyers@, PTAL.

[mlamouri (slow - plz ping), 2016-04-28 10:06:14]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[mlamouri (slow - plz ping), 2016-04-28 10:06:15]

+EMEA reviewer (jochen@). With hope :)

[jochen (gone - plz use gerrit), 2016-04-28 14:52:20]

can you include a layout test using this with this CL?

otherwise looks good

[mlamouri (slow - plz ping), 2016-04-28 14:55:31]

The layout test will come with https://codereview.chromium.org/1920863005 which
is the CL using the new content settings.

[Rick Byers, 2016-04-28 17:04:17]

Sorry for the delay.

On 2016/04/28 14:55:31, Mounir Lamouri wrote:
> The layout test will come with https://codereview.chromium.org/1920863005
which
> is the CL using the new content settings.

Usually (since the blink merge) we add test_runner support in the same CL as the
test that uses it, to make it easy for anyone looking at the history to see how
it's used in context and as extra verification that it's actually working at the
time the support lands.  Is there some reason to prefer to split the CL in two
halves like this?

[mlamouri (slow - plz ping), 2016-04-28 17:10:05]

On 2016/04/28 at 17:04:17, rbyers wrote:
> Sorry for the delay.
> 
> On 2016/04/28 14:55:31, Mounir Lamouri wrote:
> > The layout test will come with https://codereview.chromium.org/1920863005
which
> > is the CL using the new content settings.
> 
> Usually (since the blink merge) we add test_runner support in the same CL as
the test that uses it, to make it easy for anyone looking at the history to see
how it's used in context and as extra verification that it's actually working at
the time the support lands.  Is there some reason to prefer to split the CL in
two halves like this?

I like to split CLs so they touch different part of the code base because it
makes life easier for reviewers and because it makes CL handling easier for me.
In this case, the people who have to review the other CL wouldn't care much
about this one and you guys might unlikely care about the other one.

In addition, in this particular case, the other CL is blocked by a third CL from
another person and I want to reduce the number of pending code we have for this
project.

Though, if you want, I can merge.

[Rick Byers, 2016-04-28 18:02:18]

On 2016/04/28 17:10:05, Mounir Lamouri wrote:
> On 2016/04/28 at 17:04:17, rbyers wrote:
> > Sorry for the delay.
> > 
> > On 2016/04/28 14:55:31, Mounir Lamouri wrote:
> > > The layout test will come with https://codereview.chromium.org/1920863005
> which
> > > is the CL using the new content settings.
> > 
> > Usually (since the blink merge) we add test_runner support in the same CL as
> the test that uses it, to make it easy for anyone looking at the history to
see
> how it's used in context and as extra verification that it's actually working
at
> the time the support lands.  Is there some reason to prefer to split the CL in
> two halves like this?
> 
> I like to split CLs so they touch different part of the code base because it
> makes life easier for reviewers and because it makes CL handling easier for
me.
> In this case, the people who have to review the other CL wouldn't care much
> about this one and you guys might unlikely care about the other one.
> 
> In addition, in this particular case, the other CL is blocked by a third CL
from
> another person and I want to reduce the number of pending code we have for
this
> project.
> 
> Though, if you want, I can merge.

Ok, I don't have a strong opinion here, so LGTM from my perspective.  But I
guess since jochen@ raised this concern you should either give him a chance to
respond tomorrow, or just merge as he'd requested.

[mlamouri (slow - plz ping), 2016-04-29 14:33:18]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 14:33:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926773002/20001

[commit-bot: I haz the power, 2016-04-29 15:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 15:44:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mlamouri (slow - plz ping), 2016-04-29 17:12:29]

Description was changed from

==========
TestRunner: add method to instrument autoplay settings and set default value.

It adds window.testRunner.setAutoplayEnabled(bool) and sets the default
value to true (this is what LayoutTests expects today).

BUG=604751
==========

to

==========
TestRunner: add method to instrument autoplay settings and set default value.

It adds window.testRunner.setAutoplayEnabled(bool) and sets the default
value to true (this is what LayoutTests expects today).

The new method is used in the following CL:
https://codereview.chromium.org/1920863005

BUG=604751
==========

[mlamouri (slow - plz ping), 2016-04-29 17:12:40]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-04-29 17:12:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1926773002/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2016-04-29 17:12:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926773002/40001

[commit-bot: I haz the power, 2016-04-29 18:35:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:27:33]

Patchset 3 (id:??) landed as
https://crrev.com/426f286226681c8792c2261c062a73842149ba13
Cr-Commit-Position: refs/heads/master@{#390705}

[commit-bot: I haz the power, 2016-04-30 18:01:34]

Description was changed from

==========
TestRunner: add method to instrument autoplay settings and set default value.

It adds window.testRunner.setAutoplayEnabled(bool) and sets the default
value to true (this is what LayoutTests expects today).

The new method is used in the following CL:
https://codereview.chromium.org/1920863005

BUG=604751
==========

to

==========
TestRunner: add method to instrument autoplay settings and set default value.

It adds window.testRunner.setAutoplayEnabled(bool) and sets the default
value to true (this is what LayoutTests expects today).

The new method is used in the following CL:
https://codereview.chromium.org/1920863005

BUG=604751

Committed: https://crrev.com/426f286226681c8792c2261c062a73842149ba13
Cr-Commit-Position: refs/heads/master@{#390705}
==========