Disable autoplay experiments if the autoplay content settings is set to block.

Disable autoplay experiments if the autoplay content settings is set to block.

This is simply marking the HTMLMediaElement as non-eligible if the frame's
origin was blocked from autoplaying. The CL is trivial.

BUG=606802
Committed: https://crrev.com/84dabd17f567606c4ed3cf5269fc56e6c01a2f82
Cr-Commit-Position: refs/heads/master@{#391246}

[mlamouri (slow - plz ping), 2016-04-26 16:06:16]

mlamouri@chromium.org changed reviewers:
+ liberato@chromium.org

[mlamouri (slow - plz ping), 2016-04-26 16:06:16]

liberato@, PTAL. It depends on another CL of yours and another CL of mine so it
will not land now.

finnur@, FYI, you can use that for your testings. You might want to hard code
some experiments to make it easier to test.

I will look into adding some tests.

[liberato (no reviews please), 2016-04-26 16:12:06]

lgtm

[mlamouri (slow - plz ping), 2016-04-29 14:18:42]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 14:18:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920863005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920863005/20001

[liberato (no reviews please), 2016-04-29 14:41:43]

lgtm % too many test cases.

https://codereview.chromium.org/1920863005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes.html
(right):

https://codereview.chromium.org/1920863005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes.html:274:
spec.settingValue = autoplaySettings[exp % autoplaySettings.length];
might want to restrict the cases that this covers @280 or so.  the test was
hitting timeouts sometimes before i did that.  doubling the number of tests
might push it over the limit.  allowing one for 'yes' and one for 'no' should be
enough.

[mlamouri (slow - plz ping), 2016-04-29 14:54:39]

The CQ bit was unchecked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-04-29 15:19:47]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 15:20:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920863005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920863005/40001

[commit-bot: I haz the power, 2016-04-29 16:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 16:25:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mlamouri (slow - plz ping), 2016-04-29 18:51:24]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-04-29 18:51:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/1920863005/#ps40001
(title: "reduce tests")

[commit-bot: I haz the power, 2016-04-29 18:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920863005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920863005/40001

[commit-bot: I haz the power, 2016-04-29 20:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 20:10:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2016-05-03 13:47:34]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 13:47:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920863005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920863005/60001

[commit-bot: I haz the power, 2016-05-03 15:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 15:17:27]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2016-05-03 15:45:23]

i like the idea of splitting these out.  they've gotten a little too complicated
over time.

https://codereview.chromium.org/1920863005/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/audio-autoplay-experiment-modes.html
(right):

https://codereview.chromium.org/1920863005/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/audio-autoplay-experiment-modes.html:14: ==
Test Inputs ==
this should probably move into the js too.

https://codereview.chromium.org/1920863005/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/autoplay-experiment-helper.js (right):

https://codereview.chromium.org/1920863005/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/autoplay-experiment-helper.js:248: else if
(spec.visType == "obscured"
it seems weird to have the skipping logic here.

actually, it seems weird to have the skipping logic anywhere anymore, since it's
gotten so complicated.  perhaps the test should just pass in the combinations
that it wants to run in place of |experimentTypes|, rather than doing this
combinatorial thing.  it made more sense when it ran all of the (few)
combinations.

for the newly split out audio test, there are only a few combinations.  it'll be
much clearer if they're enumerated in the html.

[liberato (no reviews please), 2016-05-03 15:48:50]

lgtm

[mlamouri (slow - plz ping), 2016-05-03 15:54:32]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2016-05-03 15:56:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920863005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920863005/60001

[commit-bot: I haz the power, 2016-05-03 16:14:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-03 16:16:04]

Description was changed from

==========
Disable autoplay experiments if the autoplay content settings is set to block.

This is simply marking the HTMLMediaElement as non-eligible if the frame's
origin was blocked from autoplaying. The CL is trivial.

BUG=606802
==========

to

==========
Disable autoplay experiments if the autoplay content settings is set to block.

This is simply marking the HTMLMediaElement as non-eligible if the frame's
origin was blocked from autoplaying. The CL is trivial.

BUG=606802

Committed: https://crrev.com/84dabd17f567606c4ed3cf5269fc56e6c01a2f82
Cr-Commit-Position: refs/heads/master@{#391246}
==========

[commit-bot: I haz the power, 2016-05-03 16:16:04]

Patchset 4 (id:??) landed as
https://crrev.com/84dabd17f567606c4ed3cf5269fc56e6c01a2f82
Cr-Commit-Position: refs/heads/master@{#391246}