docserver: Load JS async defer since it really isn't required and it was blocking the loading of th…

docserver: Load JS async defer since it really isn't required and it was blocking the loading of the rest of the page.

BUG=skia:

Committed: https://skia.googlesource.com/buildbot/+/afdd788dc39a810e7621ff931d8c4a3680fefbf5

[jcgregorio, 2016-04-27 14:27:34]

jcgregorio@google.com changed reviewers:
+ benjaminwagner@google.com

[dogben, 2016-04-27 14:59:21]

lgtm

https://codereview.chromium.org/1926683002/diff/1/doc/templates/index.html
File doc/templates/index.html (right):

https://codereview.chromium.org/1926683002/diff/1/doc/templates/index.html#ne...
doc/templates/index.html:11: <script async defer src="/res/js/core.js"></script>
I think specifying both is redundant, but maybe you're trying to be compatible
with browsers that know async but not defer?

https://codereview.chromium.org/1926683002/diff/1/doc/templates/index.html#ne...
doc/templates/index.html:55: $$$('button').addEventListener('click', function(e)
{
Doesn't $$$ and $$ come from res/js/core.js? Or does DomReady not resolve until
after deferred scripts execute?

[jcgregorio, 2016-04-27 16:56:18]

https://codereview.chromium.org/1926683002/diff/1/doc/templates/index.html
File doc/templates/index.html (right):

https://codereview.chromium.org/1926683002/diff/1/doc/templates/index.html#ne...
doc/templates/index.html:11: <script async defer src="/res/js/core.js"></script>
On 2016/04/27 at 14:59:21, Ben Wagner wrote:
> I think specifying both is redundant, but maybe you're trying to be compatible
with browsers that know async but not defer?

Moved to just async.

https://codereview.chromium.org/1926683002/diff/1/doc/templates/index.html#ne...
doc/templates/index.html:55: $$$('button').addEventListener('click', function(e)
{
On 2016/04/27 at 14:59:21, Ben Wagner wrote:
> Doesn't $$$ and $$ come from res/js/core.js? Or does DomReady not resolve
until after deferred scripts execute?

Ahh, moved all this js into a file and then incorporated that file into core.js.

[jcgregorio, 2016-04-27 16:56:19]

The CQ bit was checked by jcgregorio@google.com

[jcgregorio, 2016-04-27 16:56:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjaminwagner@google.com
Link to the patchset: https://codereview.chromium.org/1926683002/#ps20001
(title: "consolidate js")

[commit-bot: I haz the power, 2016-04-27 16:56:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926683002/20001

[commit-bot: I haz the power, 2016-04-27 16:59:24]

Description was changed from

==========
docserver: Load JS async defer since it really isn't required and it was
blocking the loading of the rest of the page.

BUG=skia:
==========

to

==========
docserver: Load JS async defer since it really isn't required and it was
blocking the loading of the rest of the page.

BUG=skia:

Committed:
https://skia.googlesource.com/buildbot/+/afdd788dc39a810e7621ff931d8c4a3680fe...
==========

[commit-bot: I haz the power, 2016-04-27 16:59:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/afdd788dc39a810e7621ff931d8c4a3680fe...

[dogben, 2016-04-27 17:10:31]

https://codereview.chromium.org/1926683002/diff/20001/doc/res/js/docs.js
File doc/res/js/docs.js (right):

https://codereview.chromium.org/1926683002/diff/20001/doc/res/js/docs.js#newc...
doc/res/js/docs.js:58: var s = document.getElementsByTagName('script')[0];
Is this referring to the script element that you removed?

[jcgregorio, 2016-04-27 17:17:30]

https://codereview.chromium.org/1926683002/diff/20001/doc/res/js/docs.js
File doc/res/js/docs.js (right):

https://codereview.chromium.org/1926683002/diff/20001/doc/res/js/docs.js#newc...
doc/res/js/docs.js:58: var s = document.getElementsByTagName('script')[0];
On 2016/04/27 at 17:10:31, Ben Wagner wrote:
> Is this referring to the script element that you removed?

No, this is just code that says add this new script before the very first script
on the page.