Chromium Code Reviews Chromium Code Reviews
Issue 1926683002:
docserver: Load JS async defer since it really isn't required and it was blocking the loading of th… (Closed)
Base URL: https://skia.googlesource.com/buildbot@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <title>Docs</title> | 4 <title>Docs</title> |
| 5 <meta charset="utf-8"> | 5 <meta charset="utf-8"> |
| 6 <meta name="theme-color" content="#526E9C"> | 6 <meta name="theme-color" content="#526E9C"> |
| 7 <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | 7 <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> |
| 8 <meta name="viewport" content="width=device-width, initial-scale=1.0"> | 8 <meta name="viewport" content="width=device-width, initial-scale=1.0"> |
| 9 <meta name="google-site-verification" content="pwqU0tZr1xJubovbW73M6WGA2IIyg CYPBkB6O4kzbYI" /> | 9 <meta name="google-site-verification" content="pwqU0tZr1xJubovbW73M6WGA2IIyg CYPBkB6O4kzbYI" /> |
| 10 <meta name="google-site-verification" content="pIHubYTE28EzwOWGWmHyNmxRNA6yc lJyxSymw6uX8b8" /> | 10 <meta name="google-site-verification" content="pIHubYTE28EzwOWGWmHyNmxRNA6yc lJyxSymw6uX8b8" /> |
| 11 <script src="/res/js/core.js"></script> | 11 <script async defer src="/res/js/core.js"></script> |
|
dogben
2016/04/27 14:59:21
I think specifying both is redundant, but maybe yo
jcgregorio
2016/04/27 16:56:18
Moved to just async.
| |
| 12 <link href="/res/css/docs.css" rel="stylesheet" /> | 12 <link href="/res/css/docs.css" rel="stylesheet" /> |
| 13 </head> | 13 </head> |
| 14 <body> | 14 <body> |
| 15 <div id=page> | 15 <div id=page> |
| 16 <div id=drawer drawer vertical layout> | 16 <div id=drawer drawer vertical layout> |
| 17 <img src="/res/img/logo.png" width=204 height=91> | 17 <img src="/res/img/logo.png" width=204 height=91> |
| 18 | 18 |
| 19 <script> | 19 <script> |
| 20 (function() { | 20 (function() { |
| 21 var cx = '009791159600898516779:8-nlv0iznho'; | 21 var cx = '009791159600898516779:8-nlv0iznho'; |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 45 {{.Body}} | 45 {{.Body}} |
| 46 </div> | 46 </div> |
| 47 </div> | 47 </div> |
| 48 </div> | 48 </div> |
| 49 | 49 |
| 50 <script> | 50 <script> |
| 51 sk.DomReady.then(function() { | 51 sk.DomReady.then(function() { |
| 52 prettyPrint(); | 52 prettyPrint(); |
| 53 | 53 |
| 54 // Open the side drawer with the navigation menu. | 54 // Open the side drawer with the navigation menu. |
| 55 $$$('button').addEventListener('click', function(e) { | 55 $$$('button').addEventListener('click', function(e) { |
|
dogben
2016/04/27 14:59:21
Doesn't $$$ and $$ come from res/js/core.js? Or do
jcgregorio
2016/04/27 16:56:18
Ahh, moved all this js into a file and then incorp
| |
| 56 $$$('#drawer').classList.add('opened'); | 56 $$$('#drawer').classList.add('opened'); |
| 57 e.stopPropagation(); | 57 e.stopPropagation(); |
| 58 }); | 58 }); |
| 59 | 59 |
| 60 // Close the side drawer. | 60 // Close the side drawer. |
| 61 $$$('body').addEventListener('click', function() { | 61 $$$('body').addEventListener('click', function() { |
| 62 $$$('#drawer').classList.remove('opened'); | 62 $$$('#drawer').classList.remove('opened'); |
| 63 }); | 63 }); |
| 64 | 64 |
| 65 // highlightNav highlights where we are in the navigation. | 65 // highlightNav highlights where we are in the navigation. |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 93 }); | 93 }); |
| 94 e.preventDefault(); | 94 e.preventDefault(); |
| 95 }); | 95 }); |
| 96 }); | 96 }); |
| 97 | 97 |
| 98 highlightNav(); | 98 highlightNav(); |
| 99 }); | 99 }); |
| 100 </script> | 100 </script> |
| 101 </body> | 101 </body> |
| 102 </html> | 102 </html> |
| OLD | NEW |
