Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1926643002: Return the 'active' value for SVGURIReference.href.animVal (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Return the 'active' value for SVGURIReference.href.animVal Make animVal return the currently used ('active') value instead of always returning that of 'href'. This should re-establish the former "invariant" that baseVal === animVal when '(xlink:)href' is not being animated. BUG=606200 Review URL: https://codereview.chromium.org/1917843002 Cr-Commit-Position: refs/heads/master@{#389490} (cherry picked from commit 1d488d94b705ce49d710ba9f992f8c31a24c79e0) Committed: https://chromium.googlesource.com/chromium/src/+/187e748f9e1f2c4bb98fafcee381af8e9b052d1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/href-semantics.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedHref.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
4 years, 7 months ago (2016-04-27 11:18:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
187e748f9e1f2c4bb98fafcee381af8e9b052d1d.

Powered by Google App Engine
This is Rietveld 408576698