Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1917843002: Return the 'active' value for SVGURIReference.href.animVal (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
davve
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return the 'active' value for SVGURIReference.href.animVal Make animVal return the currently used ('active') value instead of always returning that of 'href'. This should re-establish the former "invariant" that baseVal === animVal when '(xlink:)href' is not being animated. BUG=606200 Committed: https://crrev.com/1d488d94b705ce49d710ba9f992f8c31a24c79e0 Cr-Commit-Position: refs/heads/master@{#389490}

Patch Set 1 #

Patch Set 2 : Just a note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/href-semantics.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedHref.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
4 years, 8 months ago (2016-04-25 15:11:36 UTC) #3
davve
lgtm
4 years, 8 months ago (2016-04-25 15:24:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917843002/20001
4 years, 8 months ago (2016-04-25 16:10:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 16:15:16 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 16:16:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d488d94b705ce49d710ba9f992f8c31a24c79e0
Cr-Commit-Position: refs/heads/master@{#389490}

Powered by Google App Engine
This is Rietveld 408576698