Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7038)

Unified Diff: chrome/installer/util/browser_distribution.h

Issue 1926403002: Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160406-Mac-EnableAppLauncher0
Patch Set: Remove ShortcutType Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index 2baf37d2538c691ca95f5c180f31f920c9f47caa..2a145393b053eb90693d411d83261d0cba4a2503 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -32,11 +32,6 @@ class BrowserDistribution {
NUM_TYPES
};
- enum ShortcutType {
- SHORTCUT_CHROME,
- SHORTCUT_APP_LAUNCHER
- };
-
enum Subfolder {
SUBFOLDER_CHROME,
SUBFOLDER_APPS,
@@ -83,18 +78,18 @@ class BrowserDistribution {
// Returns the localized name of the shortcut identified by |shortcut_type|
huangs 2016/05/03 18:12:02 Update comment re. |shortcut_type|.
tapted 2016/05/04 09:50:56 Done.
// for this distribution.
- virtual base::string16 GetShortcutName(ShortcutType shortcut_type);
+ virtual base::string16 GetShortcutName();
// Returns the index of the icon for the product identified by
// |shortcut_type|, inside the file specified by GetIconFilename().
huangs 2016/05/03 18:12:02 |shortcut_type|
tapted 2016/05/04 09:50:56 Done.
- virtual int GetIconIndex(ShortcutType shortcut_type);
+ virtual int GetIconIndex();
// Returns the executable filename (not path) that contains the product icon.
virtual base::string16 GetIconFilename();
// Returns the localized name of the subfolder in the Start Menu identified by
// |subfolder_type| that this distribution should create shortcuts in. For
- // SUBFOLDER_CHROME this returns GetShortcutName(SHORTCUT_CHROME).
+ // SUBFOLDER_CHROME this returns GetShortcutName().
virtual base::string16 GetStartMenuShortcutSubfolder(
Subfolder subfolder_type);

Powered by Google App Engine
This is Rietveld 408576698