Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/installer/util/browser_distribution.h

Issue 1926403002: Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160406-Mac-EnableAppLauncher0
Patch Set: Remove ShortcutType Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares a class that contains various method related to branding. 5 // This file declares a class that contains various method related to branding.
6 6
7 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_ 7 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
8 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_ 8 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
9 9
10 #include <memory> 10 #include <memory>
(...skipping 14 matching lines...) Expand all
25 25
26 class BrowserDistribution { 26 class BrowserDistribution {
27 public: 27 public:
28 enum Type { 28 enum Type {
29 CHROME_BROWSER, 29 CHROME_BROWSER,
30 CHROME_FRAME, 30 CHROME_FRAME,
31 CHROME_BINARIES, 31 CHROME_BINARIES,
32 NUM_TYPES 32 NUM_TYPES
33 }; 33 };
34 34
35 enum ShortcutType {
36 SHORTCUT_CHROME,
37 SHORTCUT_APP_LAUNCHER
38 };
39
40 enum Subfolder { 35 enum Subfolder {
41 SUBFOLDER_CHROME, 36 SUBFOLDER_CHROME,
42 SUBFOLDER_APPS, 37 SUBFOLDER_APPS,
43 }; 38 };
44 39
45 enum DefaultBrowserControlPolicy { 40 enum DefaultBrowserControlPolicy {
46 DEFAULT_BROWSER_UNSUPPORTED, 41 DEFAULT_BROWSER_UNSUPPORTED,
47 DEFAULT_BROWSER_OS_CONTROL_ONLY, 42 DEFAULT_BROWSER_OS_CONTROL_ONLY,
48 DEFAULT_BROWSER_FULL_CONTROL 43 DEFAULT_BROWSER_FULL_CONTROL
49 }; 44 };
(...skipping 24 matching lines...) Expand all
74 // Returns the unsuffixed application name of this program. 69 // Returns the unsuffixed application name of this program.
75 // This is the base of the name registered with Default Programs on Windows. 70 // This is the base of the name registered with Default Programs on Windows.
76 // IMPORTANT: This should only be called by the installer which needs to make 71 // IMPORTANT: This should only be called by the installer which needs to make
77 // decisions on the suffixing of the upcoming install, not by external callers 72 // decisions on the suffixing of the upcoming install, not by external callers
78 // at run-time. 73 // at run-time.
79 virtual base::string16 GetBaseAppName(); 74 virtual base::string16 GetBaseAppName();
80 75
81 // Returns the localized display name of this distribution. 76 // Returns the localized display name of this distribution.
82 virtual base::string16 GetDisplayName(); 77 virtual base::string16 GetDisplayName();
83 78
84 // Returns the localized name of the shortcut identified by |shortcut_type| 79 // Returns the localized name of the shortcut identified by |shortcut_type|
huangs 2016/05/03 18:12:02 Update comment re. |shortcut_type|.
tapted 2016/05/04 09:50:56 Done.
85 // for this distribution. 80 // for this distribution.
86 virtual base::string16 GetShortcutName(ShortcutType shortcut_type); 81 virtual base::string16 GetShortcutName();
87 82
88 // Returns the index of the icon for the product identified by 83 // Returns the index of the icon for the product identified by
89 // |shortcut_type|, inside the file specified by GetIconFilename(). 84 // |shortcut_type|, inside the file specified by GetIconFilename().
huangs 2016/05/03 18:12:02 |shortcut_type|
tapted 2016/05/04 09:50:56 Done.
90 virtual int GetIconIndex(ShortcutType shortcut_type); 85 virtual int GetIconIndex();
91 86
92 // Returns the executable filename (not path) that contains the product icon. 87 // Returns the executable filename (not path) that contains the product icon.
93 virtual base::string16 GetIconFilename(); 88 virtual base::string16 GetIconFilename();
94 89
95 // Returns the localized name of the subfolder in the Start Menu identified by 90 // Returns the localized name of the subfolder in the Start Menu identified by
96 // |subfolder_type| that this distribution should create shortcuts in. For 91 // |subfolder_type| that this distribution should create shortcuts in. For
97 // SUBFOLDER_CHROME this returns GetShortcutName(SHORTCUT_CHROME). 92 // SUBFOLDER_CHROME this returns GetShortcutName().
98 virtual base::string16 GetStartMenuShortcutSubfolder( 93 virtual base::string16 GetStartMenuShortcutSubfolder(
99 Subfolder subfolder_type); 94 Subfolder subfolder_type);
100 95
101 // Returns the unsuffixed appid of this program. 96 // Returns the unsuffixed appid of this program.
102 // The AppUserModelId is a property of Windows programs. 97 // The AppUserModelId is a property of Windows programs.
103 // IMPORTANT: This should only be called by ShellUtil::GetAppId as the appid 98 // IMPORTANT: This should only be called by ShellUtil::GetAppId as the appid
104 // should be suffixed in all scenarios. 99 // should be suffixed in all scenarios.
105 virtual base::string16 GetBaseAppId(); 100 virtual base::string16 GetBaseAppId();
106 101
107 // Returns the Browser ProgId prefix (e.g. ChromeHTML, ChromiumHTM, etc...). 102 // Returns the Browser ProgId prefix (e.g. ChromeHTML, ChromiumHTM, etc...).
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 168
174 std::unique_ptr<AppRegistrationData> app_reg_data_; 169 std::unique_ptr<AppRegistrationData> app_reg_data_;
175 170
176 private: 171 private:
177 BrowserDistribution(); 172 BrowserDistribution();
178 173
179 DISALLOW_COPY_AND_ASSIGN(BrowserDistribution); 174 DISALLOW_COPY_AND_ASSIGN(BrowserDistribution);
180 }; 175 };
181 176
182 #endif // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_ 177 #endif // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698