Source/core/svg/SVGAnimatedNumberList.cpp - Issue 19263002: Get rid of special casing for SVGNumber in the bindings generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAnimatedNumberList.cpp

Issue 19263002: Get rid of special casing for SVGNumber in the bindings generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix style issues Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp ('k') | Source/core/svg/SVGComponentTransferFunctionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGAnimatedNumberList.cpp

diff --git a/Source/core/svg/SVGAnimatedNumberList.cpp b/Source/core/svg/SVGAnimatedNumberList.cpp

index 21ee4a8f60cc8be1cc4cb6bd79929f7f6f2ceb7e..7f1d9e7fe7d3216c62fdbcbdb84af69accb9e8d7 100644

--- a/Source/core/svg/SVGAnimatedNumberList.cpp

+++ b/Source/core/svg/SVGAnimatedNumberList.cpp

@@ -95,9 +95,9 @@ void SVGAnimatedNumberListAnimator::calculateAnimatedValue(float percentage, uns

unsigned toAtEndOfDurationSize = toAtEndOfDurationNumberList.size();

for (unsigned i = 0; i < toNumberListSize; ++i) {

- float effectiveFrom = fromNumberListSize ? fromNumberList[i] : 0;

- float effectiveToAtEnd = i < toAtEndOfDurationSize ? toAtEndOfDurationNumberList[i] : 0;

- m_animationElement->animateAdditiveNumber(percentage, repeatCount, effectiveFrom, toNumberList[i], effectiveToAtEnd, animatedNumberList[i]);

+ float effectiveFrom = fromNumberListSize ? fromNumberList[i].value() : 0;

+ float effectiveToAtEnd = i < toAtEndOfDurationSize ? toAtEndOfDurationNumberList[i].value() : 0;

+ m_animationElement->animateAdditiveNumber(percentage, repeatCount, effectiveFrom, toNumberList[i].value(), effectiveToAtEnd, animatedNumberList[i].valueRef());

}