Issue 19263002: Get rid of special casing for SVGNumber in the bindings generator

Issue 19263002: Get rid of special casing for SVGNumber in the bindings generator (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
haraken, pdr., Stephen Chennney, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, pdr, eae+blinkwatch, leviw+renderwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, jchaffraix+rendering, Stephen Chennney, Nate Chapin, lgombos, krit

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of special casing for SVGNumber in the bindings generator Get rid of special casing for SVGNumber in the bindings generator by adding a new SVGNumber.h header containing a SVGNumber class. The implementation is now using the SVGNumber type instead of float and thus no longer requires special handling on bindings side. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154380

Patch Set 1 #

Patch Set 2 : Fix regressions #

Patch Set 3 : Build fix for mac #

Total comments: 2

Patch Set 4 : Fix style issues #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -101 lines)			Patch
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View		8 chunks	+49 lines, -65 lines	0 comments	Download
M	Source/core/core.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGAnimatedNumberList.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGComponentTransferFunctionElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGFEColorMatrixElement.cpp	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGFEConvolveMatrixElement.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	Source/core/svg/SVGNumber.h	View	1 2 3	2 chunks	+28 lines, -23 lines	0 comments	Download
M	Source/core/svg/SVGNumberList.h	View		2 chunks	+12 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGNumberList.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://codereview.chromium.org/19263002/diff/7001/Source/core/svg/SVGNumber.h File Source/core/svg/SVGNumber.h (right): https://codereview.chromium.org/19263002/diff/7001/Source/core/svg/SVGNumber.h#newcode42 Source/core/svg/SVGNumber.h:42: : m_value(0) This line should be indented four more ...

7 years, 5 months ago (2013-07-15 21:10:07 UTC) #2

do-not-use

On 2013/07/15 21:10:07, abarth wrote: > https://codereview.chromium.org/19263002/diff/7001/Source/core/svg/SVGNumber.h > File Source/core/svg/SVGNumber.h (right): > > https://codereview.chromium.org/19263002/diff/7001/Source/core/svg/SVGNumber.h#newcode42 > ...

7 years, 5 months ago (2013-07-16 06:00:09 UTC) #3

haraken

Given the discussion in https://codereview.chromium.org/19154006/, I'd like to take this CL. LGTM.

7 years, 5 months ago (2013-07-17 03:59:31 UTC) #4

pdr.

On 2013/07/17 03:59:31, haraken wrote: > Given the discussion in https://codereview.chromium.org/19154006/, I'd like to > ...

7 years, 5 months ago (2013-07-17 04:00:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19263002/13001

7 years, 5 months ago (2013-07-17 06:58:41 UTC) #6

Message was sent while issue was closed.

Change committed as 154380

Expand Messages | Collapse Messages