Erase LinkDisambiguation code on desktop.

Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org

Committed: https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c
Cr-Commit-Position: refs/heads/master@{#391698}

[Evan Stade, 2016-04-28 18:20:19]

Description was changed from

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
==========

to

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Evan Stade, 2016-04-28 18:20:53]

estade@chromium.org changed reviewers:
+ luken@chromium.org

[Evan Stade, 2016-04-28 18:20:54]

+luken, could you take a first look?

[Evan Stade, 2016-04-28 18:20:58]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 18:21:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926173002/1

[commit-bot: I haz the power, 2016-04-28 18:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 18:43:13]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Evan Stade, 2016-04-29 20:26:48]

estade@chromium.org changed reviewers:
+ cpu@chromium.org, jochen@chromium.org

[Evan Stade, 2016-04-29 20:26:49]

cpu@ and luken@ have both moved on from Chrome, so there's no natural reviewer.
Hence +jochen as owner of many files touched.

FWIW luken@ did agree to nuking the code when I chatted with him.

[jochen (gone - plz use gerrit), 2016-05-02 16:19:10]

lgtm

[cpu_(ooo_6.6-7.5), 2016-05-03 02:03:23]

https://codereview.chromium.org/1926173002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_guest.h (left):

https://codereview.chromium.org/1926173002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_guest.h:127: #endif  //
defined(OS_ANDROID) || defined(USE_AURA)
So also on android? it seems to me we are keeping android ...

[Evan Stade, 2016-05-03 16:08:09]

https://codereview.chromium.org/1926173002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_guest.h (left):

https://codereview.chromium.org/1926173002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_guest.h:127: #endif  //
defined(OS_ANDROID) || defined(USE_AURA)
On 2016/05/03 02:03:22, cpu wrote:
> So also on android? it seems to me we are keeping android ...

the implementation for this one was already a no-op.
RenderWidgetHostViewBase::ShowDisambiguationPopup is also a no op, so this
override is unnecessary, except to suppress a NOTIMPLEMENTED(). If that
NOTIMPLEMENTED() starts triggering a lot we should probably just remove it.

[Evan Stade, 2016-05-04 00:49:40]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:49:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926173002/20001

[commit-bot: I haz the power, 2016-05-04 00:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:54:14]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Evan Stade, 2016-05-04 03:00:42]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-04 03:00:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1926173002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-04 03:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926173002/40001

[commit-bot: I haz the power, 2016-05-04 03:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 03:03:06]

Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Evan Stade, 2016-05-04 22:19:57]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-04 22:19:57]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1926173002/#ps60001
(title: "another merge conflict")

[commit-bot: I haz the power, 2016-05-04 22:20:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926173002/60001

[commit-bot: I haz the power, 2016-05-04 22:28:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 22:28:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-05-04 23:17:31]

Description was changed from

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org
==========

[Evan Stade, 2016-05-04 23:17:31]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2016-05-04 23:18:11]

TBR sadrul for ui/base/ui_base_switches*

[Evan Stade, 2016-05-04 23:18:18]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-05-04 23:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926173002/60001

[commit-bot: I haz the power, 2016-05-04 23:51:46]

Description was changed from

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org
==========

to

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org
==========

[commit-bot: I haz the power, 2016-05-04 23:51:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-04 23:53:17]

Description was changed from

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org
==========

to

==========
Erase LinkDisambiguation code on desktop.

BUG=605299
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=sadrul@chromium.org

Committed: https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c
Cr-Commit-Position: refs/heads/master@{#391698}
==========

[commit-bot: I haz the power, 2016-05-04 23:53:19]

Patchset 4 (id:??) landed as
https://crrev.com/6b9696bd2d4c08b6f9fbd6224e07fcb4e1a66d0c
Cr-Commit-Position: refs/heads/master@{#391698}