Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 1926173002: Erase LinkDisambiguation code on desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another merge conflict Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 16749dd4891a0d05c71d01d27445235249d1c4f9..ed4520a18d3021adb83426e6318f057dd929f902 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -180,8 +180,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
BrowserAccessibilityDelegate* delegate, bool for_root_frame) override;
gfx::AcceleratedWidget AccessibilityGetAcceleratedWidget() override;
gfx::NativeViewAccessible AccessibilityGetNativeViewAccessible() override;
- void ShowDisambiguationPopup(const gfx::Rect& rect_pixels,
- const SkBitmap& zoomed_bitmap) override;
bool LockMouse() override;
void UnlockMouse() override;
void OnSwapCompositorFrame(
@@ -293,15 +291,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void OnLegacyWindowDestroyed();
#endif
- void DisambiguationPopupRendered(const SkBitmap& result,
- ReadbackResponse response);
-
- void HideDisambiguationPopup();
-
- void ProcessDisambiguationGesture(ui::GestureEvent* event);
-
- void ProcessDisambiguationMouse(ui::MouseEvent* event);
-
// Method to indicate if this instance is shutting down or closing.
// TODO(shrikant): Discuss around to see if it makes sense to add this method
// as part of RenderWidgetHostView.
@@ -671,13 +660,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// RenderWidgetHostViewGuest.
bool is_guest_view_hack_;
- gfx::Rect disambiguation_target_rect_;
-
- // The last scroll offset when we start to render the link disambiguation
- // view, so we can ensure the window hasn't moved between copying from the
- // compositing surface and showing the disambiguation popup.
- gfx::Vector2dF disambiguation_scroll_offset_;
-
// This flag when set ensures that we send over a notification to blink that
// the current view has focus. Defaults to false.
bool set_focus_on_mouse_down_or_key_event_;

Powered by Google App Engine
This is Rietveld 408576698