Add one more stop

Add one more stop

BUG=
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/8ffe03a9c55ff929542b599332f815c2ab415f67

[srdjan, 2016-04-28 17:37:20]

srdjan@google.com changed reviewers:
+ regis@google.com

[regis, 2016-04-28 17:53:36]

LGTM

https://codereview.chromium.org/1926133002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1926133002/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1391: Profiler::DumpStackTrace(true /*native*/);
Maybe you could also print the dart stack. The call _printCurrentStacktrace()
always works for me in the debugger.

[srdjan, 2016-04-28 18:16:19]

Thanks.

https://codereview.chromium.org/1926133002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1926133002/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1391: Profiler::DumpStackTrace(true /*native*/);
On 2016/04/28 17:53:35, regis wrote:
> Maybe you could also print the dart stack. The call _printCurrentStacktrace()
> always works for me in the debugger.

There is no Dart stack in the background compilation thread.

[regis, 2016-04-28 18:37:13]

https://codereview.chromium.org/1926133002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1926133002/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1391: Profiler::DumpStackTrace(true /*native*/);
On 2016/04/28 18:16:18, srdjan wrote:
> On 2016/04/28 17:53:35, regis wrote:
> > Maybe you could also print the dart stack. The call
_printCurrentStacktrace()
> > always works for me in the debugger.
> 
> There is no Dart stack in the background compilation thread.

Duh, never mind :-)

[srdjan, 2016-04-28 19:32:07]

Description was changed from

==========
Add one more stop

BUG=
==========

to

==========
Add one more stop

BUG=
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8ffe03a9c55ff929542b599332f815c2ab415f67
==========

[srdjan, 2016-04-28 19:32:09]

Committed patchset #2 (id:20001) manually as
8ffe03a9c55ff929542b599332f815c2ab415f67 (presubmit successful).