Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: runtime/vm/isolate.cc

Issue 1926133002: Add one more stop (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: more Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 42a4a8178cfa66c3f1789dc5d5f1c7cd9af482ee..6bcaeb6895c083d9e7709d144808fbd9e17faa3a 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1386,6 +1386,11 @@ void Isolate::Run() {
void Isolate::AddClosureFunction(const Function& function) const {
+ // TODO(regis): remove once debugging complete.
+ if (Compiler::IsBackgroundCompilation()) {
+ Profiler::DumpStackTrace(true /*native*/);
regis 2016/04/28 17:53:35 Maybe you could also print the dart stack. The cal
srdjan 2016/04/28 18:16:18 There is no Dart stack in the background compilati
regis 2016/04/28 18:37:13 Duh, never mind :-)
+ UNREACHABLE();
+ }
ASSERT(!Compiler::IsBackgroundCompilation());
GrowableObjectArray& closures =
GrowableObjectArray::Handle(object_store()->closure_functions());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698