Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926123002: Add a ctor for InterfaceRequest<I> that takes a ScopedMessagePipeHandle, and remove MakeRequest<I>(… (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a ctor for InterfaceRequest<I> that takes a ScopedMessagePipeHandle, and remove MakeRequest<I>(). InterfaceRequest is basically analogous to InterfaceHandle (and vice versa), and the latter has such a ctor. Moreover, MakeRequest doesn't really add anything and is mostly just confusing. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a53159420d12c89016169da5af18e250c62c372e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -30 lines) Patch
M mojo/application/application_runner_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/interface_factory_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/binding.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 3 chunks +7 lines, -12 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_associate.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M shell/android/android_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-04-28 17:33:24 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-04-28 17:51:14 UTC) #2
viettrungluu
4 years, 7 months ago (2016-04-28 18:02:55 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a53159420d12c89016169da5af18e250c62c372e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698