mojo/public/cpp/application/lib/application_test_base.cc - Issue 1926123002: Add a ctor for InterfaceRequest<I> that takes a ScopedMessagePipeHandle, and remove MakeRequest<I>(…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/application/lib/application_test_base.cc

Issue 1926123002: Add a ctor for InterfaceRequest<I> that takes a ScopedMessagePipeHandle, and remove MakeRequest<I>(… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/application/lib/application_runner.cc ('k') | mojo/public/cpp/application/lib/interface_factory_connector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/application/lib/application_test_base.cc

diff --git a/mojo/public/cpp/application/lib/application_test_base.cc b/mojo/public/cpp/application/lib/application_test_base.cc

index 0c57925e31f40547a8274f313ab1edde62215d6f..42519a2ce7675be8046597ec1a11e45efa9d60e0 100644

--- a/mojo/public/cpp/application/lib/application_test_base.cc

+++ b/mojo/public/cpp/application/lib/application_test_base.cc

@@ -91,7 +91,7 @@ MojoResult RunAllTests(MojoHandle application_request_handle) {

// --args-for='mojo:example_apptests arg1 --gtest_filter=foo arg2'

Array<String> args;

ShellAndArgumentGrabber grabber(

- &args, MakeRequest<Application>(MakeScopedHandle(

+ &args, InterfaceRequest<Application>(MakeScopedHandle(

MessagePipeHandle(application_request_handle))));

grabber.WaitForInitialize();

MOJO_CHECK(g_shell);