Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1926063004: Don't decompose retargeted rotate() transform transitions (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Don't decompose retargeted rotate() transform transitions 2D rotate() transform operations were always interpolating as 3D rotate() operations. This resulted in interpolations between interpolated 2D rotate()s and matching 2D rotate()s using matrix decomposition as the operation types no longer matched. This change ensures non-matrix-decomposition interpolation between rotate() operations produces the same type of rotate() operation. BUG=605021 Review URL: https://codereview.chromium.org/1909863002 Cr-Commit-Position: refs/heads/master@{#389696} (cherry picked from commit b721ba4c7c32b789911cdf125f4871f9b442320b) Committed: https://chromium.googlesource.com/chromium/src/+/127afd1b0ee3a6c937e23cd3807f2f144789e41c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/transitions/retargeted-matching-rotation-transforms.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/RotateTransformOperation.cpp View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alancutter (OOO until 2018)
4 years, 7 months ago (2016-04-29 04:03:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
127afd1b0ee3a6c937e23cd3807f2f144789e41c.

Powered by Google App Engine
This is Rietveld 408576698