Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1909863002: Don't decompose retargeted rotate() transform transitions (Closed)

Created:
4 years, 8 months ago by alancutter (OOO until 2018)
Modified:
4 years, 8 months ago
Reviewers:
jbroman
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't decompose retargeted rotate() transform transitions 2D rotate() transform operations were always interpolating as 3D rotate() operations. This resulted in interpolations between interpolated 2D rotate()s and matching 2D rotate()s using matrix decomposition as the operation types no longer matched. This change ensures non-matrix-decomposition interpolation between rotate() operations produces the same type of rotate() operation. BUG=605021 Committed: https://crrev.com/b721ba4c7c32b789911cdf125f4871f9b442320b Cr-Commit-Position: refs/heads/master@{#389696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/transitions/retargeted-matching-rotation-transforms.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/RotateTransformOperation.cpp View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alancutter (OOO until 2018)
Looks like my refactor patch to rotate() transforms inadvertently changed transition behaviour. This patch corrects ...
4 years, 8 months ago (2016-04-21 07:31:42 UTC) #2
jbroman
lgtm
4 years, 8 months ago (2016-04-21 15:21:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909863002/1
4 years, 8 months ago (2016-04-26 00:51:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 04:33:12 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 04:34:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b721ba4c7c32b789911cdf125f4871f9b442320b
Cr-Commit-Position: refs/heads/master@{#389696}

Powered by Google App Engine
This is Rietveld 408576698