LayoutTests/fast/css/calculated-length-as-percent-crash.html - Issue 192603003: ASSERTION FAILED: type() == Percent in WebCore::Length::percent

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/calculated-length-as-percent-crash.html

Issue 192603003: ASSERTION FAILED: type() == Percent in WebCore::Length::percent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@extractedstyle

Patch Set: Support for fixed table layouts, test update and comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Julien - ping for review 2014/06/23 17:09:57 Also the test is not checking for a test anymore s Also the test is not checking for a test anymore so we should rename it.
	2 <html>

	3 <script src="../../resources/check-layout.js"></script>

	4 <body onload="checkLayout('td')">
	Julien - ping for review 2014/06/23 17:09:23 Let's add a description of what we are testing ple Let's add a description of what we are testing please.
	5 <table>

	6 <tr>

	7 <td colspan="5" style="width: calc(100% + 100px);" data-expected-wid th="2"/>
	Julien - ping for review 2014/06/23 17:09:23 That works because you have no content so it's cor That works because you have no content so it's correct. I would just put a <div style="height: 100px; width: 100px"> to have some content (you will probably have to remove the 2px padding on cells). I would also check: - both the width and height - the table itself
	8 </tr>

	9 </table>

	10

	11 <table style="table-layout:fixed;">

	12 <tr>

	13 <td colspan="5" style="width: calc(100% + 100px);" data-expected-wid th="2"/>

	14 </tr>

	15 </table>

	16

	17 </body>

	18 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/calculated-length-as-percent-crash-expected.txt » ('j') | Source/core/rendering/AutoTableLayout.cpp » ('J')