ASSERTION FAILED: type() == Percent in WebCore::Length::percent

Source/core/rendering/AutoTableLayout.cpp

 /*
  * Copyright (C) 2002 Lars Knoll (knoll@kde.org)
  *           (C) 2002 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2006, 2008, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License.
  *
@@ skipping 69 matching lines @@
                     if (cell->maxPreferredLogicalWidth() > columnLayout.maxLogicalWidth) {
                         columnLayout.maxLogicalWidth = cell->maxPreferredLogicalWidth();
                         maxContributor = cell;
                     }
 
                     // All browsers implement a size limit on the cell's max width.
                     // Our limit is based on KHTML's representation that used 16 bits widths.
                     // FIXME: Other browsers have a lower limit for the cell's max width.
                     const int cCellMaxWidth = 32760;
                     Length cellLogicalWidth = cell->styleOrColLogicalWidth();
+                    // FIXME: calc() on tables should be handled consistently with other lengths. See bug: https://crbug.com/382725
+                    if (cellLogicalWidth.isCalculated())
+                        cellLogicalWidth = Length(); // make it Auto

[Julien - ping for review, 2014/06/23 17:09:24]

For consistency, we should capitalize Make.

                     if (cellLogicalWidth.value() > cCellMaxWidth)
                         cellLogicalWidth.setValue(cCellMaxWidth);
                     if (cellLogicalWidth.isNegative())
                         cellLogicalWidth.setValue(0);
                     switch (cellLogicalWidth.type()) {
                     case Fixed:
                         // ignore width=0
                         if (cellLogicalWidth.isPositive() && !columnLayout.logicalWidth.isPercent()) {
                             int logicalWidth = cell->adjustBorderBoxLogicalWidthForBoxSizing(cellLogicalWidth.value());
                             if (columnLayout.logicalWidth.isFixed()) {
@@ skipping 186 matching lines @@
     }
 
     for (size_t i = 0; i < m_spanCells.size(); ++i) {
         RenderTableCell* cell = m_spanCells[i];
         if (!cell)
             break;
 
         unsigned span = cell->colSpan();
 
         Length cellLogicalWidth = cell->styleOrColLogicalWidth();
-        if (cellLogicalWidth.isZero())
+        // FIXME: calc() on tables should be handled consistently with other lengths. See bug: https://crbug.com/382725
+        if (cellLogicalWidth.isZero() || cellLogicalWidth.isCalculated())
             cellLogicalWidth = Length(); // make it Auto

[Julien - ping for review, 2014/06/23 17:09:23]

Ditto.

 
         unsigned effCol = m_table->colToEffCol(cell->col());
         size_t lastCol = effCol;
         int cellMinLogicalWidth = cell->minPreferredLogicalWidth() + spacingInRowDirection;
         int cellMaxLogicalWidth = cell->maxPreferredLogicalWidth() + spacingInRowDirection;
         float totalPercent = 0;
         int spanMinLogicalWidth = 0;
         int spanMaxLogicalWidth = 0;
         bool allColsArePercent = true;
         bool allColsAreFixed = true;
@@ skipping 418 matching lines @@
 
     int pos = 0;
     for (size_t i = 0; i < nEffCols; ++i) {
         m_table->setColumnPosition(i, pos);
         pos += m_layoutStruct[i].computedLogicalWidth + m_table->hBorderSpacing();
     }
     m_table->setColumnPosition(m_table->columnPositions().size() - 1, pos);
 }
 
 }