Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1926023002: [turbofan] Run everything after representation selection concurrently. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run everything after representation selection concurrently. Further refactor the pipeline to even run the first scheduler (part of the effect control linearization) concurrently. This temporarily disables most of the write barrier elimination, but we will get back to that later. Drive-by-fix: Remove the dead code from ChangeLowering, and stack allocate the Typer in the pipeline. Also migrate the AllocateStub to a native code builtin, so that we have the code object + a handle to it available all the time. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel R=mstarzinger@chromium.org BUG=v8:4969 LOG=n Committed: https://crrev.com/d1b3d426ceae45e13ccf30cd4ac6e99e2bb8baf6 Cr-Commit-Position: refs/heads/master@{#35918}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Feedback addressed #

Patch Set 3 : Fix TSAN issues and some related issues, by using a low-level allocate primitive. #

Patch Set 4 : Remove some dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -301 lines) Patch
M src/arm/builtins-arm.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/code-stubs.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/change-lowering.h View 1 2 2 chunks +11 lines, -25 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 2 7 chunks +41 lines, -147 lines 0 comments Download
M src/compiler/common-node-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-graph.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/linkage.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +18 lines, -23 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 2 chunks +17 lines, -3 lines 0 comments Download
M src/handles.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/interface-descriptors.h View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 58 (34 generated)
Benedikt Meurer
Hey Michi, As discussed, here's the next concurrent step. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-04-28 11:51:16 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1926023002/diff/1/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/1926023002/diff/1/src/compiler/change-lowering.cc#newcode101 src/compiler/change-lowering.cc:101: // if (field_type->Is(Type::TaggedSigned()) || Can we at least ...
4 years, 7 months ago (2016-04-28 12:18:17 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1926023002/diff/1/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/1926023002/diff/1/src/compiler/change-lowering.cc#newcode101 src/compiler/change-lowering.cc:101: // if (field_type->Is(Type::TaggedSigned()) || Done https://codereview.chromium.org/1926023002/diff/1/src/compiler/instruction.cc File src/compiler/instruction.cc (right): ...
4 years, 7 months ago (2016-04-28 12:20:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/20001
4 years, 7 months ago (2016-04-28 12:21:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 12:53:33 UTC) #8
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1925073002/ by machenbach@chromium.org. ...
4 years, 7 months ago (2016-04-28 13:13:17 UTC) #9
Michael Achenbach
TSAN fails the most: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/9255
4 years, 7 months ago (2016-04-28 13:25:06 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/20001
4 years, 7 months ago (2016-04-28 18:01:22 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_tsan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_tsan_rel/builds/214)
4 years, 7 months ago (2016-04-28 18:34:09 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/40001
4 years, 7 months ago (2016-04-28 18:35:17 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/13767) v8_mac_rel_ng on ...
4 years, 7 months ago (2016-04-28 18:37:50 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/60001
4 years, 7 months ago (2016-04-28 19:02:18 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/16931) v8_linux_arm64_rel_ng on ...
4 years, 7 months ago (2016-04-28 19:04:50 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/80001
4 years, 7 months ago (2016-04-29 18:04:42 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/950) v8_linux_mips64el_compile_rel on ...
4 years, 7 months ago (2016-04-29 18:06:12 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/100001
4 years, 7 months ago (2016-04-30 18:05:51 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17002) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-04-30 18:08:22 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/120001
4 years, 7 months ago (2016-04-30 18:10:51 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17003) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-04-30 18:13:22 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/140001
4 years, 7 months ago (2016-04-30 18:17:11 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023002/160001
4 years, 7 months ago (2016-04-30 18:37:11 UTC) #52
commit-bot: I haz the power
Committed patchset #4 (id:160001)
4 years, 7 months ago (2016-04-30 19:00:45 UTC) #54
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e045a06625ceb442e732630e6584191b5e72b6b6 Cr-Commit-Position: refs/heads/master@{#35861}
4 years, 7 months ago (2016-05-01 22:02:22 UTC) #56
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:04:15 UTC) #58
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d1b3d426ceae45e13ccf30cd4ac6e99e2bb8baf6
Cr-Commit-Position: refs/heads/master@{#35918}

Powered by Google App Engine
This is Rietveld 408576698