Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1925963002: InitEvent should not do anything if dispatch flag is set. (Closed)

Created:
4 years, 7 months ago by ramya.v
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

InitEvent should not do anything if dispatch flag is set. Spec: https://dom.spec.whatwg.org/#concept-event-initialize BUG=563973 Committed: https://crrev.com/d6092343be0905a49c51199f0210be7124b3f8d2 Cr-Commit-Position: refs/heads/master@{#390348}

Patch Set 1 #

Patch Set 2 : Updated as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
D third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/events/Event-propagation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/events/CompositionEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/CustomEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/Event.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MutationEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TextEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
ramya.v
PTAL! Thanks
4 years, 7 months ago (2016-04-28 06:59:38 UTC) #2
tkent
We should update all of initFooEvent() functions, and should remove Event::dispatched().
4 years, 7 months ago (2016-04-28 07:08:48 UTC) #3
philipj_slow
This is my last week at Opera so I'm unable to take on new reviews, ...
4 years, 7 months ago (2016-04-28 09:39:47 UTC) #5
ramya.v
Updated as per review comments. PTAL! Thanks
4 years, 7 months ago (2016-04-28 10:32:26 UTC) #7
tkent
lgtm
4 years, 7 months ago (2016-04-28 10:49:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925963002/20001
4 years, 7 months ago (2016-04-28 10:49:35 UTC) #10
mlamouri (slow - plz ping)
lgtm
4 years, 7 months ago (2016-04-28 11:57:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 12:04:35 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:33 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d6092343be0905a49c51199f0210be7124b3f8d2
Cr-Commit-Position: refs/heads/master@{#390348}

Powered by Google App Engine
This is Rietveld 408576698