Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/core/events/KeyboardEvent.cpp

Issue 1925963002: InitEvent should not do anything if dispatch flag is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de) 3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 * Copyright (C) 2003, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 initLocationModifiers(location); 106 initLocationModifiers(location);
107 } 107 }
108 108
109 KeyboardEvent::~KeyboardEvent() 109 KeyboardEvent::~KeyboardEvent()
110 { 110 {
111 } 111 }
112 112
113 void KeyboardEvent::initKeyboardEvent(ScriptState* scriptState, const AtomicStri ng& type, bool canBubble, bool cancelable, AbstractView* view, 113 void KeyboardEvent::initKeyboardEvent(ScriptState* scriptState, const AtomicStri ng& type, bool canBubble, bool cancelable, AbstractView* view,
114 const String& keyIdentifier, unsigned location, bool ctrlKey, bool altKey, b ool shiftKey, bool metaKey) 114 const String& keyIdentifier, unsigned location, bool ctrlKey, bool altKey, b ool shiftKey, bool metaKey)
115 { 115 {
116 if (dispatched()) 116 if (isBeingDispatched())
117 return; 117 return;
118 118
119 if (scriptState->world().isIsolatedWorld()) 119 if (scriptState->world().isIsolatedWorld())
120 UIEventWithKeyState::didCreateEventInIsolatedWorld(ctrlKey, altKey, shif tKey, metaKey); 120 UIEventWithKeyState::didCreateEventInIsolatedWorld(ctrlKey, altKey, shif tKey, metaKey);
121 121
122 initUIEvent(type, canBubble, cancelable, view, 0); 122 initUIEvent(type, canBubble, cancelable, view, 0);
123 123
124 m_keyIdentifier = keyIdentifier; 124 m_keyIdentifier = keyIdentifier;
125 m_location = location; 125 m_location = location;
126 initModifiers(ctrlKey, altKey, shiftKey, metaKey); 126 initModifiers(ctrlKey, altKey, shiftKey, metaKey);
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 break; 191 break;
192 } 192 }
193 } 193 }
194 194
195 DEFINE_TRACE(KeyboardEvent) 195 DEFINE_TRACE(KeyboardEvent)
196 { 196 {
197 UIEventWithKeyState::trace(visitor); 197 UIEventWithKeyState::trace(visitor);
198 } 198 }
199 199
200 } // namespace blink 200 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/events/Event.cpp ('k') | third_party/WebKit/Source/core/events/MessageEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698