Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: net/http/http_cache.cc

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments from Patch set 1 and 3 and merge with TOT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache.cc
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index e4319e10a2d732005d6782c01429b92e033b6b54..c41bbe95d88a597186a7d8a09a537aa92425f288 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -275,8 +275,9 @@ class HttpCache::QuicServerInfoFactoryAdaptor : public QuicServerInfoFactory {
: http_cache_(http_cache) {
}
- virtual QuicServerInfo* GetForHost(const std::string& hostname) OVERRIDE {
- return new DiskCacheBasedQuicServerInfo(hostname, http_cache_);
+ virtual QuicServerInfo* GetForHostPortPair(
wtc 2014/03/11 01:41:39 Nit: we can name this method "GetForServer". Then
Ryan Hamilton 2014/03/11 15:47:43 Nice! Or, if we're going to include scheme, we co
ramant (doing other things) 2014/03/13 01:50:12 Done.
ramant (doing other things) 2014/03/13 01:50:12 Acknowledged. Used GetServer per wtc's suggestion.
+ const HostPortPair& host_port_pair) OVERRIDE {
+ return new DiskCacheBasedQuicServerInfo(host_port_pair, http_cache_);
}
private:

Powered by Google App Engine
This is Rietveld 408576698