QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname

net/http/http_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_cache.h"
 
 #include <algorithm>
 
 #include "base/compiler_specific.h"
 
@@ skipping 257 matching lines @@
 }
 
 //-----------------------------------------------------------------------------
 
 class HttpCache::QuicServerInfoFactoryAdaptor : public QuicServerInfoFactory {
  public:
   QuicServerInfoFactoryAdaptor(HttpCache* http_cache)
       : http_cache_(http_cache) {
   }
 
-  virtual QuicServerInfo* GetForHost(const std::string& hostname) OVERRIDE {
-    return new DiskCacheBasedQuicServerInfo(hostname, http_cache_);
+  virtual QuicServerInfo* GetForHostPortPair(

[wtc, 2014/03/11 01:41:39]

Nit: we can name this method "GetForServer". Then it's just a matter of how we
represent a server (by its hostname, by a host-port pair, or by
scheme://host:port).

[Ryan Hamilton, 2014/03/11 15:47:43]

Nice!  Or, if we're going to include scheme, we could also consider origin.

[ramant (doing other things), 2014/03/13 01:50:12]

Done.

[ramant (doing other things), 2014/03/13 01:50:12]

Acknowledged. Used GetServer per wtc's suggestion.

+      const HostPortPair& host_port_pair) OVERRIDE {
+    return new DiskCacheBasedQuicServerInfo(host_port_pair, http_cache_);
   }
 
  private:
   HttpCache* const http_cache_;
 };
 
 //-----------------------------------------------------------------------------
 HttpCache::HttpCache(const net::HttpNetworkSession::Params& params,
                      BackendFactory* backend_factory)
     : net_log_(params.net_log),
@@ skipping 882 matching lines @@
     building_backend_ = false;
     DeletePendingOp(pending_op);
   }
 
   // The cache may be gone when we return from the callback.
   if (!item->DoCallback(result, disk_cache_.get()))
     item->NotifyTransaction(result, NULL);
 }
 
 }  // namespace net