remove 'deprecated' region from SkDraw

remove 'deprecated' region from SkDraw

Most call-sites that used it just took its bounds, so it was trivial to convert them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925693002

Committed: https://skia.googlesource.com/skia/+/1e7f5e708e5daeb0c18ae49001c9e3cd5e3b13cb

[reed1, 2016-04-27 13:46:00]

Description was changed from

==========
remove 'deprecated' region from SkDraw

Most call-sites that used it just took its bounds, so it was trivial to convert
them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
==========

to

==========
remove 'deprecated' region from SkDraw

Most call-sites that used it just took its bounds, so it was trivial to convert
them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-04-27 13:46:14]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 13:46:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/1

[reed1, 2016-04-27 13:46:29]

reed@google.com changed reviewers:
+ djsollen@google.com, halcanary@google.com

[commit-bot: I haz the power, 2016-04-27 13:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 13:47:30]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[reed1, 2016-04-27 13:51:32]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 13:51:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/20001

[commit-bot: I haz the power, 2016-04-27 13:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 13:53:30]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[reed1, 2016-04-27 13:54:37]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 13:54:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/40001

[commit-bot: I haz the power, 2016-04-27 13:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 13:57:19]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[djsollen, 2016-04-27 13:57:53]

https://codereview.chromium.org/1925693002/diff/40001/src/utils/SkCanvasState...
File src/utils/SkCanvasStateUtils.cpp (right):

https://codereview.chromium.org/1925693002/diff/40001/src/utils/SkCanvasState...
src/utils/SkCanvasStateUtils.cpp:254: setup_MC_state(&layerState->mcState,
layer.matrix(), layer.clip().bwRgn());
can we put an assert here the the clip is BW?

[reed1, 2016-04-27 14:00:30]

On 2016/04/27 13:57:53, djsollen wrote:
>
https://codereview.chromium.org/1925693002/diff/40001/src/utils/SkCanvasState...
> File src/utils/SkCanvasStateUtils.cpp (right):
> 
>
https://codereview.chromium.org/1925693002/diff/40001/src/utils/SkCanvasState...
> src/utils/SkCanvasStateUtils.cpp:254: setup_MC_state(&layerState->mcState,
> layer.matrix(), layer.clip().bwRgn());
> can we put an assert here the the clip is BW?

bwRgn() does the assert for you

[reed1, 2016-04-27 14:06:02]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 14:06:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/60001

[reed1, 2016-04-27 14:07:09]

reed@google.com changed reviewers:
+ bungeman@google.com

[reed1, 2016-04-27 14:07:10]

+bunge for xps

[commit-bot: I haz the power, 2016-04-27 14:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:09:23]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2016-04-27 14:12:26]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 14:12:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/80001

[hal.canary, 2016-04-27 14:14:37]

still reading this....

https://codereview.chromium.org/1925693002/diff/1/include/core/SkDraw.h
File include/core/SkDraw.h (right):

https://codereview.chromium.org/1925693002/diff/1/include/core/SkDraw.h#newco...
include/core/SkDraw.h:151: const SkClipStack* fClipStack;  // optional
better documentation?  what does optional mean?  is fClipStack ever NULL?

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.cpp
File src/core/SkRasterClip.cpp (right):

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.cpp#n...
src/core/SkRasterClip.cpp:63: if (isEqual) {
SkASSERT(!isEqual || fIsEmpty == other.fIsEmpty);
SkASSERT(!isEqual || fIsRect == other.fIsRect);

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.h
File src/core/SkRasterClip.h (right):

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.h#new...
src/core/SkRasterClip.h:16: class SkRasterClip {
documentation:  what is a rasterclip?

[reed1, 2016-04-27 14:25:20]

https://codereview.chromium.org/1925693002/diff/1/include/core/SkDraw.h
File include/core/SkDraw.h (right):

https://codereview.chromium.org/1925693002/diff/1/include/core/SkDraw.h#newco...
include/core/SkDraw.h:151: const SkClipStack* fClipStack;  // optional
On 2016/04/27 14:14:37, Hal Canary wrote:
> better documentation?  what does optional mean?  is fClipStack ever NULL?

Done.

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.cpp
File src/core/SkRasterClip.cpp (right):

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.cpp#n...
src/core/SkRasterClip.cpp:63: if (isEqual) {
On 2016/04/27 14:14:37, Hal Canary wrote:
> SkASSERT(!isEqual || fIsEmpty == other.fIsEmpty);
> SkASSERT(!isEqual || fIsRect == other.fIsRect);

I find that harder to parse. Do you see other benefits?

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.h
File src/core/SkRasterClip.h (right):

https://codereview.chromium.org/1925693002/diff/1/src/core/SkRasterClip.h#new...
src/core/SkRasterClip.h:16: class SkRasterClip {
On 2016/04/27 14:14:37, Hal Canary wrote:
> documentation:  what is a rasterclip?

Done.

https://codereview.chromium.org/1925693002/diff/40001/src/utils/SkCanvasState...
File src/utils/SkCanvasStateUtils.cpp (right):

https://codereview.chromium.org/1925693002/diff/40001/src/utils/SkCanvasState...
src/utils/SkCanvasStateUtils.cpp:254: setup_MC_state(&layerState->mcState,
layer.matrix(), layer.clip().bwRgn());
On 2016/04/27 13:57:53, djsollen wrote:
> can we put an assert here the the clip is BW?

That is done automatically by calling bwRgn()

[reed1, 2016-04-27 14:25:28]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 14:25:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/100001

[hal.canary, 2016-04-27 14:35:53]

pdf: lgtm

[commit-bot: I haz the power, 2016-04-27 14:46:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:46:01]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-04-27 14:48:11]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-04-27 14:48:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925693002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925693002/100001

[commit-bot: I haz the power, 2016-04-27 14:49:20]

Description was changed from

==========
remove 'deprecated' region from SkDraw

Most call-sites that used it just took its bounds, so it was trivial to convert
them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
remove 'deprecated' region from SkDraw

Most call-sites that used it just took its bounds, so it was trivial to convert
them
to get the bounds of the RasterClip. Two clients wanted the actual region:
1. layeriter for android
2. pdf

Android already only has BW clips, so should be safe.
PDF now overrides its clip methods to ensure that all clips are BW.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1e7f5e708e5daeb0c18ae49001c9e3cd5e3b13cb
==========

[commit-bot: I haz the power, 2016-04-27 14:49:21]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/1e7f5e708e5daeb0c18ae49001c9e3cd5e3b13cb