Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1925683002: Add simple bit_cast unittests (Closed)

Created:
4 years, 7 months ago by tsniatowski
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add simple bit_cast unittests, avoid static_assert on gcc+libc++ These should work provided that the is_trivially_copyable logic is not broken, and will fail to compile of the type traits lie. They do on Android where we have gcc+libc++, so avoid being too strict there. BUG=607158 Committed: https://crrev.com/474f4a511b7bdbfcf09c1e914ee99fd9e35db0f8 Cr-Commit-Position: refs/heads/master@{#390472}

Patch Set 1 #

Patch Set 2 : Fix bit_cast.h, fix windows test compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/bit_cast.h View 1 1 chunk +3 lines, -1 line 0 comments Download
A base/bit_cast_unittest.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tsniatowski
On 2016/04/27 13:39:45, tsniatowski wrote: > mailto:tsniatowski@opera.com changed reviewers: > + mailto:thakis@chromium.org Try jobs failed ...
4 years, 7 months ago (2016-04-27 13:58:54 UTC) #3
Nico
lgtm What's the plan here -- ifdef this out on Android with a TODO pointing ...
4 years, 7 months ago (2016-04-27 16:46:37 UTC) #4
tsniatowski
On 2016/04/27 16:46:37, Nico wrote: > lgtm > > What's the plan here -- ifdef ...
4 years, 7 months ago (2016-04-28 11:45:48 UTC) #5
Nico
On 2016/04/28 11:45:48, tsniatowski wrote: > On 2016/04/27 16:46:37, Nico wrote: > > lgtm > ...
4 years, 7 months ago (2016-04-28 20:38:33 UTC) #6
tsniatowski
On 2016/04/28 20:38:33, Nico wrote: > On 2016/04/28 11:45:48, tsniatowski wrote: > > On 2016/04/27 ...
4 years, 7 months ago (2016-04-28 20:43:09 UTC) #8
Nico
still lgtm, thanks!
4 years, 7 months ago (2016-04-28 20:45:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925683002/20001
4 years, 7 months ago (2016-04-28 20:47:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 20:53:29 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:55 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/474f4a511b7bdbfcf09c1e914ee99fd9e35db0f8
Cr-Commit-Position: refs/heads/master@{#390472}

Powered by Google App Engine
This is Rietveld 408576698