Add simple bit_cast unittests

Add simple bit_cast unittests, avoid static_assert on gcc+libc++

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie. They do on
Android where we have gcc+libc++, so avoid being too strict there.

BUG=607158
Committed: https://crrev.com/474f4a511b7bdbfcf09c1e914ee99fd9e35db0f8
Cr-Commit-Position: refs/heads/master@{#390472}

[tsniatowski, 2016-04-27 13:39:44]

Description was changed from

==========
Add simple bit_cast unittests

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie.

BUG=607158
==========

to

==========
Add simple bit_cast unittests

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie.

BUG=607158
==========

[tsniatowski, 2016-04-27 13:39:45]

tsniatowski@opera.com changed reviewers:
+ thakis@chromium.org

[tsniatowski, 2016-04-27 13:58:54]

On 2016/04/27 13:39:45, tsniatowski wrote:
> mailto:tsniatowski@opera.com changed reviewers:
> + mailto:thakis@chromium.org

Try jobs failed as expected because android thinks that a struct A { int a; } is
not std::trivially_copyable, and dies with a static_assert in bit_cast.h

[Nico, 2016-04-27 16:46:37]

lgtm

What's the plan here -- ifdef this out on Android with a TODO pointing at the
bug?

[tsniatowski, 2016-04-28 11:45:48]

On 2016/04/27 16:46:37, Nico wrote:
> lgtm
> 
> What's the plan here -- ifdef this out on Android with a TODO pointing at the
> bug?

I think it might be better to fix the ifdefs in bit_cast.h to avoid hitting the
problematic gcc libc++ interaction, will add a fix here in a sec.

[Nico, 2016-04-28 20:38:33]

On 2016/04/28 11:45:48, tsniatowski wrote:
> On 2016/04/27 16:46:37, Nico wrote:
> > lgtm
> > 
> > What's the plan here -- ifdef this out on Android with a TODO pointing at
the
> > bug?
> 
> I think it might be better to fix the ifdefs in bit_cast.h to avoid hitting
the
> problematic gcc libc++ interaction, will add a fix here in a sec.

Sounds great, looking forward to it!

[tsniatowski, 2016-04-28 20:42:19]

Description was changed from

==========
Add simple bit_cast unittests

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie.

BUG=607158
==========

to

==========
Add simple bit_cast unittests, avoid static_assert on gcc+libc++

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie. They do on
Android where we have gcc+libc++, so avoid being too strict there.

BUG=607158
==========

[tsniatowski, 2016-04-28 20:43:09]

On 2016/04/28 20:38:33, Nico wrote:
> On 2016/04/28 11:45:48, tsniatowski wrote:
> > On 2016/04/27 16:46:37, Nico wrote:
> > > lgtm
> > > 
> > > What's the plan here -- ifdef this out on Android with a TODO pointing at
> the
> > > bug?
> > 
> > I think it might be better to fix the ifdefs in bit_cast.h to avoid hitting
> the
> > problematic gcc libc++ interaction, will add a fix here in a sec.
> 
> Sounds great, looking forward to it!

reworded description since this now makes the bit_cast change in addition to
adding the trivial unit tests

[Nico, 2016-04-28 20:45:51]

still lgtm, thanks!

[tsniatowski, 2016-04-28 20:46:57]

The CQ bit was checked by tsniatowski@opera.com

[commit-bot: I haz the power, 2016-04-28 20:47:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925683002/20001

[commit-bot: I haz the power, 2016-04-28 20:53:29]

Description was changed from

==========
Add simple bit_cast unittests, avoid static_assert on gcc+libc++

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie. They do on
Android where we have gcc+libc++, so avoid being too strict there.

BUG=607158
==========

to

==========
Add simple bit_cast unittests, avoid static_assert on gcc+libc++

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie. They do on
Android where we have gcc+libc++, so avoid being too strict there.

BUG=607158
==========

[commit-bot: I haz the power, 2016-04-28 20:53:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:20:55]

Patchset 2 (id:??) landed as
https://crrev.com/474f4a511b7bdbfcf09c1e914ee99fd9e35db0f8
Cr-Commit-Position: refs/heads/master@{#390472}

[commit-bot: I haz the power, 2016-04-30 17:57:22]

Description was changed from

==========
Add simple bit_cast unittests, avoid static_assert on gcc+libc++

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie. They do on
Android where we have gcc+libc++, so avoid being too strict there.

BUG=607158
==========

to

==========
Add simple bit_cast unittests, avoid static_assert on gcc+libc++

These should work provided that the is_trivially_copyable logic is not
broken, and will fail to compile of the type traits lie. They do on
Android where we have gcc+libc++, so avoid being too strict there.

BUG=607158

Committed: https://crrev.com/474f4a511b7bdbfcf09c1e914ee99fd9e35db0f8
Cr-Commit-Position: refs/heads/master@{#390472}
==========