Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: base/bit_cast.h

Issue 1925683002: Add simple bit_cast unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bit_cast.h, fix windows test compile Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/base.gyp ('k') | base/bit_cast_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_BIT_CAST_H_ 5 #ifndef BASE_BIT_CAST_H_
6 #define BASE_BIT_CAST_H_ 6 #define BASE_BIT_CAST_H_
7 7
8 #include <string.h> 8 #include <string.h>
9 #include <type_traits> 9 #include <type_traits>
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 // calls to memcpy() with inline object code when the size argument is a 58 // calls to memcpy() with inline object code when the size argument is a
59 // compile-time constant. On a 32-bit system, memcpy(d,s,4) compiles to one 59 // compile-time constant. On a 32-bit system, memcpy(d,s,4) compiles to one
60 // load and one store, and memcpy(d,s,8) compiles to two loads and two stores. 60 // load and one store, and memcpy(d,s,8) compiles to two loads and two stores.
61 61
62 template <class Dest, class Source> 62 template <class Dest, class Source>
63 inline Dest bit_cast(const Source& source) { 63 inline Dest bit_cast(const Source& source) {
64 static_assert(sizeof(Dest) == sizeof(Source), 64 static_assert(sizeof(Dest) == sizeof(Source),
65 "bit_cast requires source and destination to be the same size"); 65 "bit_cast requires source and destination to be the same size");
66 66
67 #if (__GNUC__ > 5 || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1) || \ 67 #if (__GNUC__ > 5 || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1) || \
68 defined(_LIBCPP_VERSION)) 68 (defined(__clang__) && defined(_LIBCPP_VERSION)))
69 // GCC 5.1 contains the first libstdc++ with is_trivially_copyable. 69 // GCC 5.1 contains the first libstdc++ with is_trivially_copyable.
70 // Assume libc++ Just Works: is_trivially_copyable added on May 13th 2011. 70 // Assume libc++ Just Works: is_trivially_copyable added on May 13th 2011.
71 // However, with libc++ when GCC is the compiler the trait is buggy, see
72 // crbug.com/607158, so fall back to the less strict variant for non-clang.
71 static_assert(std::is_trivially_copyable<Dest>::value, 73 static_assert(std::is_trivially_copyable<Dest>::value,
72 "non-trivially-copyable bit_cast is undefined"); 74 "non-trivially-copyable bit_cast is undefined");
73 static_assert(std::is_trivially_copyable<Source>::value, 75 static_assert(std::is_trivially_copyable<Source>::value,
74 "non-trivially-copyable bit_cast is undefined"); 76 "non-trivially-copyable bit_cast is undefined");
75 #elif HAS_FEATURE(is_trivially_copyable) 77 #elif HAS_FEATURE(is_trivially_copyable)
76 // The compiler supports an equivalent intrinsic. 78 // The compiler supports an equivalent intrinsic.
77 static_assert(__is_trivially_copyable(Dest), 79 static_assert(__is_trivially_copyable(Dest),
78 "non-trivially-copyable bit_cast is undefined"); 80 "non-trivially-copyable bit_cast is undefined");
79 static_assert(__is_trivially_copyable(Source), 81 static_assert(__is_trivially_copyable(Source),
80 "non-trivially-copyable bit_cast is undefined"); 82 "non-trivially-copyable bit_cast is undefined");
81 #elif COMPILER_GCC 83 #elif COMPILER_GCC
82 // Fallback to compiler intrinsic on GCC and clang (which pretends to be 84 // Fallback to compiler intrinsic on GCC and clang (which pretends to be
83 // GCC). This isn't quite the same as is_trivially_copyable but it'll do for 85 // GCC). This isn't quite the same as is_trivially_copyable but it'll do for
84 // our purpose. 86 // our purpose.
85 static_assert(__has_trivial_copy(Dest), 87 static_assert(__has_trivial_copy(Dest),
86 "non-trivially-copyable bit_cast is undefined"); 88 "non-trivially-copyable bit_cast is undefined");
87 static_assert(__has_trivial_copy(Source), 89 static_assert(__has_trivial_copy(Source),
88 "non-trivially-copyable bit_cast is undefined"); 90 "non-trivially-copyable bit_cast is undefined");
89 #else 91 #else
90 // Do nothing, let the bots handle it. 92 // Do nothing, let the bots handle it.
91 #endif 93 #endif
92 94
93 Dest dest; 95 Dest dest;
94 memcpy(&dest, &source, sizeof(dest)); 96 memcpy(&dest, &source, sizeof(dest));
95 return dest; 97 return dest;
96 } 98 }
97 99
98 #endif // BASE_BIT_CAST_H_ 100 #endif // BASE_BIT_CAST_H_
OLDNEW
« no previous file with comments | « base/base.gyp ('k') | base/bit_cast_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698