Chromium Code Reviews

Issue 1925613002: [chrome.displaySource] Add client thread checks to encoders. (Closed)

Created:
4 years, 7 months ago by e_hakkinen
Modified:
4 years, 7 months ago
Reviewers:
shalamov, Mikhail
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, asargent_no_longer_on_chrome
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Add client thread checks to encoders. Wi-Fi Display encoder client code should belong to a single thread. This CL adds DCHECKS to check that. BUG=242107 Committed: https://crrev.com/5c7cc01e4697559aeaf708adeac8661726fede2f Cr-Commit-Position: refs/heads/master@{#390064}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+5 lines, -0 lines)
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.h View 2 chunks +2 lines, -0 lines 0 comments
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc View 1 chunk +1 line, -0 lines 0 comments
M extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc View 2 chunks +2 lines, -0 lines 1 comment

Messages

Total messages: 10 (3 generated)
e_hakkinen
PTAL.
4 years, 7 months ago (2016-04-27 11:04:08 UTC) #2
Mikhail
https://codereview.chromium.org/1925613002/diff/1/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc File extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc (right): https://codereview.chromium.org/1925613002/diff/1/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc#newcode34 extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc:34: DCHECK(client_thread_checker_.CalledOnValidThread()); how about audio encoder and the implementations (vea, ...
4 years, 7 months ago (2016-04-27 11:07:48 UTC) #3
e_hakkinen
On 2016/04/27 11:07:48, Mikhail wrote: > how about audio encoder and the implementations (vea, svc, ...
4 years, 7 months ago (2016-04-27 13:10:24 UTC) #4
Mikhail
lgtm
4 years, 7 months ago (2016-04-27 13:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925613002/1
4 years, 7 months ago (2016-04-27 13:35:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 14:14:42 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 14:16:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c7cc01e4697559aeaf708adeac8661726fede2f
Cr-Commit-Position: refs/heads/master@{#390064}

Powered by Google App Engine