extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc - Issue 1925613002: [chrome.displaySource] Add client thread checks to encoders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc

Issue 1925613002: [chrome.displaySource] Add client thread checks to encoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.h ('k') | extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc » ('j') | extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc

diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc b/extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc

index 4245f0457dd5d875321de127e1df3ef593068fad..760f57b56ce37bc9224a4211b46ded8926f84176 100644

--- a/extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc

+++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_media_encoder.cc

@@ -33,6 +33,7 @@ WiFiDisplayMediaEncoder::~WiFiDisplayMediaEncoder() = default;

void WiFiDisplayMediaEncoder::SetCallbacks(

const EncodedUnitCallback& encoded_callback,

const base::Closure& error_callback) {

+ DCHECK(client_thread_checker_.CalledOnValidThread());

// This is not thread-safe if encoding has been started thus allow

// this to be called only once.

DCHECK(encoded_callback_.is_null() && error_callback_.is_null());