third_party/WebKit/Source/web/CompositorMutatorImpl.cpp - Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

Issue 1925583003: Replace AllowCrossThreadAccess() + non-GCed pointers with crossThreadUnretained() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_4

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

diff --git a/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp b/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

index 79709e134294ab2c1c17c51d879023e2fd222fdb..b1e3bb7d55e49c49738cef3ff5052e8bccd86bc2 100644

--- a/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

+++ b/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

@@ -41,7 +41,7 @@ std::unique_ptr<CompositorMutatorClient> CompositorMutatorImpl::createClient()

std::unique_ptr<CompositorMutatorClient> mutatorClient;

WaitableEvent doneEvent;

if (WebThread* compositorThread = Platform::current()->compositorThread()) {

- compositorThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&createCompositorMutatorClient, AllowCrossThreadAccess(&mutatorClient), AllowCrossThreadAccess(&doneEvent)));

+ compositorThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&createCompositorMutatorClient, crossThreadUnretained(&mutatorClient), crossThreadUnretained(&doneEvent)));

} else {

createCompositorMutatorClient(&mutatorClient, &doneEvent);

}