third_party/WebKit/Source/platform/graphics/FrameData.h - Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/FrameData.h

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits related to review #31 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/graphics/FrameData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/FrameData.h

diff --git a/third_party/WebKit/Source/platform/graphics/FrameData.h b/third_party/WebKit/Source/platform/graphics/FrameData.h

index e64c9318bd54efa3417f2bfbbe91dfd52d9bc8f2..8324f83d5e5f3f71476b439cbfa931d71fc3e3a1 100644

--- a/third_party/WebKit/Source/platform/graphics/FrameData.h

+++ b/third_party/WebKit/Source/platform/graphics/FrameData.h

@@ -29,7 +29,6 @@

#define FrameData_h

#include "platform/graphics/ImageOrientation.h"

-#include "third_party/skia/include/core/SkImage.h"

#include "wtf/Allocator.h"

#include "wtf/Noncopyable.h"

#include "wtf/RefPtr.h"

@@ -46,9 +45,8 @@ public:

// Clear the cached image data on the frame, and (optionally) the metadata.

// Returns whether there was cached image data to clear.

- bool clear(bool clearMetadata);

+ void clear(bool clearMetadata);

- RefPtr<SkImage> m_frame;

ImageOrientation m_orientation;

float m_duration;

bool m_haveMetadata : 1;