third_party/WebKit/Source/platform/graphics/FrameData.cpp - Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/FrameData.cpp

Issue 1925533003: High CPU and increased memory usage fix for high-res (GIF, WEBP...) animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits related to review #31 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/graphics/FrameData.h ('k') | third_party/WebKit/Source/platform/graphics/GeneratedImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/FrameData.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/FrameData.cpp b/third_party/WebKit/Source/platform/graphics/FrameData.cpp

index b510aa935bccb53d3144cc6f4a3e9a5ac7cb0e2e..3edfe4f745baada4d323a970118b43745df95249 100644

--- a/third_party/WebKit/Source/platform/graphics/FrameData.cpp

+++ b/third_party/WebKit/Source/platform/graphics/FrameData.cpp

@@ -43,19 +43,13 @@ FrameData::~FrameData()

clear(true);

}

-bool FrameData::clear(bool clearMetadata)

+void FrameData::clear(bool clearMetadata)

{

if (clearMetadata)

m_haveMetadata = false;

m_orientation = DefaultImageOrientation;

m_frameBytes = 0;

- if (m_frame) {

- m_frame.clear();

- return true;

- }

- return false;

}

} // namespace blink