Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(876)

Issue 1925463003: [turbofan] Don't use the CompareIC in JSGenericLowering. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, oth, PaweĊ‚ Hajdan Jr., rmcilroy, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't use the CompareIC in JSGenericLowering. This is essentially a cherry-pick that was applied before plus the removal of a test that is now failing because it depends on more involved changes. The test case checks comparison of different undetectable JSReceivers, which is not relevant in practice, as there's only one of these at most, which is document.all. Merged 55b4df7357557eb16377ad9227e4e0a4224b7885 Merged d00da47b61462681b48e48bdff4a80a33da1a6d6 Merged 4da2e3dbcfc686f68e56c0ad5575257dc2d8ccf1 Merged c1507e158780b170f25f0f1da87cb5d78a56faee [runtime] Unify comparison operator runtime entries. [turbofan] Don't use the CompareIC in JSGenericLowering. PPC: [runtime] Unify comparison operator runtime entries. PPC: [turbofan] Don't use the CompareIC in JSGenericLowering. R=yangguo@chromium.org BUG=chromium:590832, v8:4788, chromium:606181 LOG=N NOTRY=true NOPRESUBMIT=true Cr-Commit-Position: refs/branch-heads/5.0@{#13} Cr-Branched-From: ad16e6c2cbd2c6b0f2e8ff944ac245561c682ac2-refs/heads/5.0.71@{#1} Cr-Branched-From: bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030-refs/heads/master@{#34215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -391 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +12 lines, -106 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +14 lines, -11 lines 0 comments Download
M src/interpreter/interpreter.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +9 lines, -11 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/runtime/runtime-operators.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-4788-1.js View 1 chunk +25 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4788-2.js View 1 chunk +25 lines, -0 lines 0 comments Download
M test/mjsunit/undetectable-compare.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/runtime/runtime-interpreter-unittest.cc View 2 chunks +0 lines, -99 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Benedikt Meurer
4 years, 5 months ago (2016-04-27 05:38:38 UTC) #1
Yang
On 2016/04/27 05:38:38, Benedikt Meurer wrote: LGTM (rubberstamp).
4 years, 5 months ago (2016-04-27 05:39:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925463003/1
4 years, 5 months ago (2016-04-27 05:40:24 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-04-27 05:40:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698