Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1777503002: Version 5.0.71.10 (cherry-pick) (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, oth, Paweł Hajdan Jr., rmcilroy, v8-mips-ports_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

Version 5.0.71.10 (cherry-pick) Merged 55b4df7357557eb16377ad9227e4e0a4224b7885 Merged d00da47b61462681b48e48bdff4a80a33da1a6d6 Merged 4da2e3dbcfc686f68e56c0ad5575257dc2d8ccf1 Merged c1507e158780b170f25f0f1da87cb5d78a56faee [runtime] Unify comparison operator runtime entries. [turbofan] Don't use the CompareIC in JSGenericLowering. PPC: [runtime] Unify comparison operator runtime entries. PPC: [turbofan] Don't use the CompareIC in JSGenericLowering. R=hablich@chromium.org BUG=chromium:590832, v8:4788 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/0843a173996f5f63eca749d6fe8c20d4813537d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -390 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +12 lines, -106 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +14 lines, -11 lines 0 comments Download
M src/interpreter/interpreter.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +9 lines, -11 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/runtime/runtime-operators.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-4788-1.js View 1 chunk +25 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4788-2.js View 1 chunk +25 lines, -0 lines 0 comments Download
M test/unittests/runtime/runtime-interpreter-unittest.cc View 2 chunks +0 lines, -99 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-08 12:01:03 UTC) #1
Michael Hablich
On 2016/03/08 12:01:03, Michael Starzinger wrote: lgtm
4 years, 9 months ago (2016-03-08 12:04:37 UTC) #2
Michael Starzinger
Committed patchset #1 (id:1) manually as 0843a173996f5f63eca749d6fe8c20d4813537d9.
4 years, 9 months ago (2016-03-08 12:18:21 UTC) #4
Michael Starzinger
4 years, 9 months ago (2016-03-08 14:51:46 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1775883003/ by mstarzinger@chromium.org.

The reason for reverting is: This makes "mjsunit/undetectable-compare" fail,
some previous drive-by-fix might be missing from the branch that allows us to
make the switch away from the CompareIC. This is no longer a quick-fix that can
be merged back and we are essentially flying blind on the branch. I am no longer
confident that the quick-fix can be merged back. Reverting..

Powered by Google App Engine
This is Rietveld 408576698