Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1925273002: [Closure Externs] Fix presubmit check (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
Reviewers:
jam, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Closure Externs] Fix presubmit check Have the presubmit script check all affected files instead of only those in the presubmit directory. Avoids false positives. BUG=469920 Committed: https://crrev.com/1136682513fe0203a80747c1803b3f3d328a27a9 Cr-Commit-Position: refs/heads/master@{#390968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M PRESUBMIT_test_mocks.py View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/externs_checker.py View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/externs_checker_test.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Devlin
4 years, 7 months ago (2016-04-28 19:05:30 UTC) #3
Dan Beam
lgtm
4 years, 7 months ago (2016-04-29 21:45:12 UTC) #4
Devlin
+jam for PRESUBMIT_test_mocks.py
4 years, 7 months ago (2016-04-29 22:13:13 UTC) #6
jam
lgtm
4 years, 7 months ago (2016-05-02 15:34:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925273002/1
4 years, 7 months ago (2016-05-02 16:28:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 17:06:08 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 17:07:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1136682513fe0203a80747c1803b3f3d328a27a9
Cr-Commit-Position: refs/heads/master@{#390968}

Powered by Google App Engine
This is Rietveld 408576698